Bug #105760
closed
Cached Settings in site configuration (multi domain setup)
100%
Description
Hey, i have a multidomain setup (v12 => v13 upgrade) with a settings.yaml for each site which contains some pids like
publication:
detailPid: 123
listPid: 456
storagePid: 789
These settings are used in typoscript plugin config (and later in php/fluid):
plugin.tx_customer_publication {
settings {
listPid = {$publication.listPid}
detailPid = {$publication.detailPid}
storagePid = {$publication.storagePid}
}
}
the first site get’s the correct site settings as expected, calling the second site afterwards it gets the same settings as the first site instead of it’s own custom settings, they seem to be cached.
I also made a testcase with a plain TYPO3 instance:
Created 2 site configs and add settings to site config (separated settings.yaml made no difference):
base: 'https://plain-typo3-13.ddev.site/autogenerated-1'
errorHandling: { }
languages:
-
title: English
enabled: true
languageId: 0
base: /
locale: en_US.UTF-8
navigationTitle: English
flag: us
rootPageId: 1
routes: { }
settings:
testParam: 111
and
base: 'https://plain-typo3-13.ddev.site/autogenerated-2'
errorHandling: { }
languages:
-
title: English
enabled: true
languageId: 0
base: /
locale: en_US.UTF-8
navigationTitle: English
flag: us
rootPageId: 2
routes: { }
settings:
testParam: 222
Created a typoscript template in backend on each root page to output the setting:
page = PAGE
page {
typeNum = 0
10 = TEXT
10.value = {$testParam}
10.insertData = 1
}
Calling first page returns 111, calling second page afterwards also returns 111 instead of 222.
I also have checked the cache/code/core/SiteSettings_* files, they look fine.
Updated by David Hoeckele about 2 months ago
the base urls in the example are 'https://plain-typo3-13.ddev.site/autogenerated-1' and 'https://plain-typo3-13.ddev.site/autogenerated-2', not both 'https://plain-typo3-13.ddev.site/autogenerated-2', sorry for the typo in the example.
Updated by Garvin Hicking about 2 months ago
- Category set to Site Handling, Site Sets & Routing
Updated by Benjamin Franzke about 2 months ago
· Edited
Thanks for your report.
One question in order to understand why you face this error with v13 and not with v12:
Did you migrate from sys_template to site-sets in v13 (in that case I'm pretty sure that the error is a missing site-reference in the typoscript cache key [1]) or did you stay with sys_template records?
Edit: Sorry, I just noticed that you wrote "Created a typoscript template in backend on each root page", so you're still using sys_template records. CC @Christian Kuhn
Updated by Benjamin Franzke about 2 months ago
- Related to Bug #104544: TypoScript cache of nested Site Sets are not unique in Frontend added
Updated by David Hoeckele about 2 months ago
No, I did not migrate to site-sets (yet), i tried to stay with sys_template records.
It's a large TYPO3 with over 100 sites and a lots of special cases - so i'd prefer to stay with sys_template records for v13 (or is it not recommended to use it that way in v13?)
Updated by Benjamin Franzke about 2 months ago
Perfectly fine to stay with sys_template in v13, no intent to remove or deprecate that in nearest future.
I actually only asked about that in order to isolate the root cause of the issue.
We'll try to have a look at this.
Updated by Kevin Appelt about 1 month ago
@Benjamin Franzke We have the same issue using site sets.
(see: https://typo3.slack.com/archives/C03AM9R17/p1734511495355159 - my slack message from today - 2024-12-18@09:44am)
Updated by Christian Kuhn about 1 month ago
- Related to Feature #97816: New TypoScript parser added
Updated by Gerrit Code Review about 1 month ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87557
Updated by Benjamin Franzke about 1 month ago
Kevin Appelt wrote in #note-8:
@Benjamin Franzke We have the same issue using site sets.
(see: https://typo3.slack.com/archives/C03AM9R17/p1734511495355159 - my slack message from today - 2024-12-18@09:44am)
That's another issue, please create a separate ticket.
Will be fixed a separate patch:
87555: [WIP][BUGFIX] Respect per-site settings in TypoScript cache identifiers | https://review.typo3.org/c/Packages/TYPO3.CMS/+/87555
Updated by Christian Kuhn about 1 month ago
- Related to Bug #104858: SiteSettings->get() does return values for nested arrays in subproperties added
Updated by Gerrit Code Review about 1 month ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87557
Updated by Gerrit Code Review about 1 month ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87557
Updated by Gerrit Code Review about 1 month ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87557
Updated by Gerrit Code Review about 1 month ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87557
Updated by Gerrit Code Review about 1 month ago
Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87557
Updated by Gerrit Code Review about 1 month ago
Patch set 1 for branch 13.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87570
Updated by Benjamin Franzke about 1 month ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset a84e10c738f9d4f00be69d2d187cf257aea8b70e.