TYPO3 Core

The tx_linkvalidator_broken_links.record_pid always contains the pid of the content record. For pages, this is inconvenient because we need the uid, not the pid. We always need the page id.

It would be better if we generally store the page id instead of the pid.

The current state requires a lot of awkward DB queries where we have to consider pages and non-pages seperately:

For example:

->where(
                    $queryBuilder->expr()->or(
                        $queryBuilder->expr()->and(
                            $queryBuilder->expr()->in(
                                'record_uid',
                                $queryBuilder->quoteArrayBasedValueListToIntegerList($pageIdsChunk)
                            ),
                            $queryBuilder->expr()->eq('table_name', $queryBuilder->quote('pages'))
                        ),
                        $queryBuilder->expr()->and(
                            $queryBuilder->expr()->in(
                                'record_pid',
                                $queryBuilder->quoteArrayBasedValueListToIntegerList($pageIdsChunk)
                            ),
                            $queryBuilder->expr()->neq('table_name', $queryBuilder->quote('pages'))
                        )
                    )

https://github.com/TYPO3/typo3/blob/83a4a08b2a47534746593ae23f0d6e870f714f53/typo3/sysext/linkvalidator/Classes/Repository/BrokenLinkRepository.php#L107C17-L123C22

 $constraints = [
                $queryBuilder->expr()->or(
                    $queryBuilder->expr()->and(
                        $queryBuilder->expr()->in(
                            'record_uid',
                            $queryBuilder->quoteArrayBasedValueListToIntegerList($pageIdsChunk)
                        ),
                        $queryBuilder->expr()->eq('table_name', $queryBuilder->quote('pages'))
                    ),
                    $queryBuilder->expr()->and(
                        $queryBuilder->expr()->in(
                            'record_pid',
                            $queryBuilder->quoteArrayBasedValueListToIntegerList($pageIdsChunk)
                        ),
                        $queryBuilder->expr()->neq('table_name', $queryBuilder->quote('pages'))
                    )
                ),

https://github.com/TYPO3/typo3/blob/83a4a08b2a47534746593ae23f0d6e870f714f53/typo3/sysext/linkvalidator/Classes/Repository/BrokenLinkRepository.php#L266C12-L282C19

etc. ....