Project

General

Profile

Actions

Bug #105883

closed

Recycler does not work for editors unless they may also delete records

Added by Lina Wolf 5 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Recycler
Target version:
-
Start date:
2025-01-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
8.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

TYPO3 13.4.2

Non-admin editors cannot see any items in the recycler unless the page TSconfig option

# Allow the editors to delete records
mod.recycler.allowDelete = 1

is set. This option allows editors to permanently delete records. So there are valid use
cases where editors should be able to use the reset feature without being able to permanently
delete records


Files

image_720.png (21.9 KB) image_720.png Lina Wolf, 2025-01-04 16:37
Actions #1

Updated by Ursula Klinger 4 months ago ยท Edited

Hi,

we debugged this today. We think it is a javascript error (visible in the developer console),
where "remove" is called on a non-existing massDelete button (document.querySelector(Identifiers.massDelete).remove()).
The same happens with the style (document.querySelector(Identifiers.massDelete).style.display).
Unfortunately we could not fix the error ourselves, because we only see the public javascript file.
We hope this helps somebody to fix it.

Actions #2

Updated by Garvin Hicking 4 months ago

Hi Ursula,

Thanks for offering to help. I'm a bit unsure if this is really related, but it shouldn't hurt to help analyzing the JavaScript.

The .js files are built from the TYPO3 core monorepository. You could:

- check out the GIT repository of the matching TYPO3 release you use
- find the .ts file in the /Build/Sources/ structure of the GIT repo
- make changes
- run the command ./Build/Scripts/runTests.sh -s buildJavascript which will create the updated .js file
- copy that js file to your actual instance
- reload browser cache to ensure the new JS is used
- debug, rinse, repeat

(If you set-up the monorepository as an actual TYPO3 instance you could use a JS build watch task to constantly update the .js file(s) to speed up the process)

Maybe this helps to get you into it? Thanks for helping !

Actions #3

Updated by Gerrit Code Review 4 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88173

Actions #4

Updated by Gerrit Code Review 4 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88173

Actions #5

Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88173

Actions #6

Updated by Gerrit Code Review 4 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88173

Actions #7

Updated by Gerrit Code Review 4 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88173

Actions #8

Updated by Gerrit Code Review 4 months ago

Patch set 1 for branch 13.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88233

Actions #9

Updated by Ursula Klinger 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF