Project

General

Profile

Actions

Bug #105910

closed

Wrong record icon in linkvalidator

Added by Philipp Kitzberger 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2025-01-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
14
PHP Version:
Tags:
Complexity:
trivial
Is Regression:
Sprint Focus:

Description

The icons rendered in the link validator result view are always the wrong ones since the data that's being used to render them is wrong.

Here's a excerpt from EXT:linkvalidator/Classes/Controller/LinkValidatorController.php with $row being the link validator record not the target record!

    protected function generateTableRow(array $row): array
    {
    ...
        $result = [
            'uid' => $row['uid'],
            'recordUid' => $row['record_uid'],
            'recordTable' => $table,
            'recordTableTitle' => $languageService->sL($GLOBALS['TCA'][$table]['ctrl']['title'] ?? ''),
            'recordTableIconDefault' => $this->iconFactory->getIconForRecord($table, $row, IconSize::SMALL)->render(),
    ...
    }

That's why the record icons are not the ones one would expect: correct type icon with optional overlay (for hidden=1)

Current state:

Fixed state:


Files

clipboard-202501101326-n988b.png (53.3 KB) clipboard-202501101326-n988b.png Philipp Kitzberger, 2025-01-10 12:26
clipboard-202501101327-udbcx.png (53 KB) clipboard-202501101327-udbcx.png Philipp Kitzberger, 2025-01-10 12:27
Actions #1

Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87692

Actions #3

Updated by Philipp Kitzberger 4 months ago ยท Edited

  • % Done changed from 0 to 100

Yup, it's working in 13.4.5 now. Thanks.

Actions #4

Updated by Garvin Hicking 4 months ago

  • Status changed from Under Review to Closed
Actions

Also available in: Atom PDF