Bug #105910
closedWrong record icon in linkvalidator
100%
Description
The icons rendered in the link validator result view are always the wrong ones since the data that's being used to render them is wrong.
Here's a excerpt from EXT:linkvalidator/Classes/Controller/LinkValidatorController.php with $row
being the link validator record not the target record!
protected function generateTableRow(array $row): array { ... $result = [ 'uid' => $row['uid'], 'recordUid' => $row['record_uid'], 'recordTable' => $table, 'recordTableTitle' => $languageService->sL($GLOBALS['TCA'][$table]['ctrl']['title'] ?? ''), 'recordTableIconDefault' => $this->iconFactory->getIconForRecord($table, $row, IconSize::SMALL)->render(), ... }
That's why the record icons are not the ones one would expect: correct type icon with optional overlay (for hidden=1)
Current state:
Fixed state:
Files
Updated by Gerrit Code Review 5 months ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87692
Updated by Georg Ringer 4 months ago
fixed with https://github.com/typo3/typo3/commit/a68c980dea477bffdf786858733d3ac45f3de0bd, can you retest?
Updated by Philipp Kitzberger 4 months ago
ยท Edited
- % Done changed from 0 to 100
Yup, it's working in 13.4.5 now. Thanks.
Updated by Garvin Hicking 4 months ago
- Status changed from Under Review to Closed