Project

General

Profile

Actions

Bug #105989

open

Extbase-based backend modules for f:be.tableList have no localized "Cancel" button

Added by Garvin Hicking 16 days ago. Updated 10 days ago.

Status:
Under Review
Priority:
Should have
Category:
Backend User Interface
Target version:
Start date:
2025-01-25
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The Fluid ViewHelper f:be.tableList uses the sysext/backend/Classes/RecordList/DatabaseRecordList.php
method makeControl to render a "Delete" button inside record lists.

Clicking on that link uses Build/Sources/TypeScript/backend/ajax-data-handler.ts which localizes
the modal popup contents with either the strings of anchorElement.dataset.buttonCloseText
or TYPO3.lang['button.cancel'] as a fallback.

In the extbase-based backend module, that TYPO3.lang fallback index is not available/set,
and returns a JavaScript error:

VM7262 ajax-data-handler.js:13 Uncaught TypeError: Cannot read properties of undefined (reading 'button.cancel')
    at HTMLButtonElement.<anonymous> (VM7262 ajax-data-handler.js:13:1730)
    at HTMLDocument.<anonymous> (VM7215 regular-event.js:13:433)

To fix this, the makeControl() method now also utilizes not only
data-button-ok-text but also data-button-close-text so that the reliance on
TYPO3.lang no longer is required.

All other methods in the TYPO3 core that set data-button-ok-text always
also populate that data attribute, so this patch streamlines this
bevhaviour.

Actions #1

Updated by Gerrit Code Review 16 days ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87883

Actions #2

Updated by Gerrit Code Review 15 days ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87883

Actions #3

Updated by Gerrit Code Review 14 days ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87883

Actions #4

Updated by Gerrit Code Review 14 days ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87883

Actions #5

Updated by Gerrit Code Review 11 days ago

Patch set 1 for branch 13.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87953

Actions #6

Updated by Gerrit Code Review 11 days ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87954

Actions #7

Updated by Gerrit Code Review 10 days ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87883

Actions #8

Updated by Gerrit Code Review 10 days ago

Patch set 2 for branch 13.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87953

Actions #9

Updated by Gerrit Code Review 10 days ago

Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/87954

Actions

Also available in: Atom PDF