Project

General

Profile

Actions

Bug #106084

open

TYPO3 Upgrade Wizard marked as done before it can ever run

Added by Daniel Siepmann 6 days ago. Updated 6 days ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2025-02-05
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The Upgrade Wizard SysFileCollectionIdentifierMigration with identifier sysFileCollectionIdentifierMigration can never be executed when updating from v11 to v13.
This is as the TYPO3 code first calls updateNecessary() on the wizard before checking the getPrerequisites()

The wizard will report no update is necessary, as the new field to migrate to does not exist yet.
The wizard will be marked as done, and never be executed again.

I would expect the UpgradeWizardRunCommand to check the prerequisites before calling any other code on the wizards.
But if it is intended, this should be documented, and the wizard needs to be changed to also run if any column is missing. That way the pre conditions will be evaluated and ensured prior executing the wizard.

Current workaround is to manually run database:updateschema before, to add new columns, but not delete any columns.

Related documentation: https://docs.typo3.org/m/typo3/reference-coreapi/13.4/en-us/ExtensionArchitecture/HowTo/UpdateExtensions/UpdateWizards/Creation.html
This does not explain anything about my assumptions and should probably be improved to clearly state how to use updateNecessary() and what to expect, e.g. whether the preconditions will be met before, or between checking and execution.

Steps to reproduce:
- Install v13
- import attached dump
- execute ./vendor/bin/typo3 upgrade:run -vvv;

Or manually:
- Create a database from TYPO3 v11
- Create one db row within sys_file_collection
- Switch to v13
- execute ./vendor/bin/typo3 upgrade:run -vvv;

I didn't test in v12 where the wizard was added, but it might be an issue there as well.
I also couldn't find a proper Category related to the wizard.


Files

dump.sql (5.61 KB) dump.sql Daniel Siepmann, 2025-02-05 07:44
Actions #1

Updated by Daniel Siepmann 6 days ago

Actions #2

Updated by Daniel Siepmann 6 days ago

  • Description updated (diff)
Actions #3

Updated by Daniel Siepmann 6 days ago

  • Description updated (diff)
Actions

Also available in: Atom PDF