Project

General

Profile

Actions
Copy link

Bug #106170

closed

Attaching images to content elements via element browser is broken in Firefox

Added by Garvin Hicking about 1 month ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Must have
Assignee:
-
Category:
Backend User Interface
Target version:
next-patchlevel
Start date:
2025-02-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

It seems with Firefox (134.0.2) the changes in element-browser.js create an error, which does not happen with Chromium. It somehow seems related to CORS and the FF security model for accessing a frame?

See screenshot.

Reverting element-browser.js to the version of TYPO3 13.4.4 makes it work again.

Slack discussion thread: https://typo3.slack.com/archives/C025BQLFA/p1739386874937549

Files

Download all files
Screenshot from 2025-02-12 19-51-26.png (136 KB) Screenshot from 2025-02-12 19-51-26.png original error output in browser console Garvin Hicking, 2025-02-13 13:58
Screenshot 2025-02-14 at 12.02.04.png (1.05 MB) Screenshot 2025-02-14 at 12.02.04.png debugger state, having patch-set 3 applied from Gerrit Oliver Hader, 2025-02-14 11:03

Related issues 2 (0 open — 2 closed)

Related to TYPO3 Core - Bug #97466: Adding an image with filelist won't workResolved2022-04-25

Actions
Related to TYPO3 Core - Bug #105172: Filepicker (Element Browser) closing without creating the link to FileResolved2024-10-01

Actions
Actions
Copy link
 #1

Updated by Garvin Hicking about 1 month ago

  • Related to Bug #97466: Adding an image with filelist won't work added
  • Related to Bug #105172: Filepicker (Element Browser) closing without creating the link to File added
Actions
Copy link
 #2

Updated by Garvin Hicking about 1 month ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Garvin Hicking about 1 month ago

  • Subject changed from Attaching images to Content elements is broken to Attaching images to content elements via element browser is broken in Firefox
Actions
Copy link
 #4

Updated by Garvin Hicking about 1 month ago

Update: The reason is LastPass. It seems to inject custom iframes, which the new JS code tries to access (because it thinks the iframes belongs to TYPO3).

A solution would be to check the iterated iframes if they are really accessible.

Actions
Copy link
 #5

Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88212

Actions
Copy link
 #6

Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88212

Actions
Copy link
 #7

Updated by Gerrit Code Review about 1 month ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88212

Actions
Copy link
 #9

Updated by Oliver Hader about 1 month ago

Side-note:

I registered a free account of LastPast.com, installed the browser extension and was able to reproduce the original (faulty) behavior.

Actions
Copy link
 #10

Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 13.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88245

Actions
Copy link
 #11

Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88246

Actions
Copy link
 #12

Updated by Garvin Hicking about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF