Project

General

Profile

Actions
Copy link

Task #106184

open

Only update node_modules if package-lock.json has changed

Added by Ayke Halder 27 days ago. Updated 27 days ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2025-02-16
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Each time running commands like

./Build/Scripts/runTests.sh -s lintHtml

./Build/Scripts/runTests.sh -s lintScss
./Build/Scripts/runTests.sh -s buildCss

./Build/Scripts/runTests.sh -s lintTypescript
./Build/Scripts/runTests.sh -s unitJavascript
./Build/Scripts/runTests.sh -s buildJavascript

./Build/Scripts/runTests.sh -s checkGruntClean

the command npm ci (clean-install) is triggered. This removes all files inside node_modules folder and then all node-modules are newly installed.

The reason for using npm ci is that all package versions are installed like locked in package-lock.json.
Where-as npm install might do minor-version package updates.

Running npm ci takes unnecessary time itself and additionally recreating the node_modules folder triggers IDE indexing actions.

Actions
Copy link
 #1

Updated by Gerrit Code Review 27 days ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88239

Actions
Copy link
 #2

Updated by Gerrit Code Review 27 days ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/88239

Actions
Copy link

Also available in: Atom PDF