Task #10911

Task #26664: Clean up Form ViewHelpers

Task #26658: Make Form ViewHelpers consistent

Tx_Fluid_ViewHelpers_Form_AbstractFormViewHelper->renderHiddenIdentityField should be more reliable

Added by Patrick Schriner about 10 years ago. Updated over 9 years ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
ViewHelpers
Target version:
-
Start date:
2010-11-17
Due date:
% Done:

0%

Estimated time:
Has patch:
No

Description

(Poor title)

$name = $this->prefixFieldName($name) . '[__identity]';

The problem with this line is that if this lookup resorts to an empty string, fluid will fail during a security check:

#1255072832: The form field name "[__identity]" is invalid. Reason: "[]" used not as last argument. 

Tx_Extbase_Security_Exception_InvalidArgumentForRequestHashGeneration thrown in file W:\TYPO3Winstaller\htdocs\Dummy\typo3\sysext\extbase\Classes\Security\Channel\RequestHashService.php in line 94.

I'm pretty sure that a mistake of mine led to renderHiddenIdentityField behaving this way, yet I don't see the point in creating misleading & invalid output.

#1

Updated by Patrick Schriner about 10 years ago

okay, I found the reason - this happens when FormViewHelper->getFormObjectName() returns null; This happens when name is not set (which should not happen).

Still I think it could be less misleading if an error on this missing piece of configuration were raised.

#2

Updated by Sebastian Kurfuerst over 9 years ago

  • Parent task set to #26658
#3

Updated by Robert Lemke over 9 years ago

  • Target version changed from 1.0 beta 2 to 1.0.0
#4

Updated by Robert Lemke over 9 years ago

  • Target version deleted (1.0.0)
  • Has patch set to No

Not FLOW3 related?

Also available in: Atom PDF