Bug #13333

AOP for methods with references do not work.

Added by Martin Eisengardt almost 10 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Should have
Category:
AOP
Start date:
2011-02-24
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
No
Complexity:

Description

Tried to log a method call to GenericPod\Backend->storeObject (fourth parameter is a reference to an array)

//    
//    /**
//     * logging
//     *
//     * @param \F3\FLOW3\AOP\JoinPointInterface $joinPoint The current join point
//     * @return void
//     * @around method(F3\FLOW3\Persistence\Backend\GenericPdo\Backend->storeObject())
//     */
//    public function logStoreObject(\F3\FLOW3\AOP\JoinPointInterface $joinPoint)
//    {
//        $object = $joinPoint->getMethodArgument('object');
//        $id = $joinPoint->getMethodArgument('identifier');
//        $parent = $joinPoint->getMethodArgument('parentIdentifier');
//        $data = $joinPoint->getMethodArgument('objectData');
//        
//        $this->logger->log('GenericPDOBackend->storeObject(['.get_class($object).'], '.$id.', '.$parent.', ...)');
//        
//        $result = $joinPoint->getAdviceChain()->proceed($joinPoint);
//        return $result;
//    }

error/exception:

Warning: Parameter 4 to F3\FLOW3\Persistence\Backend\GenericPdo\Backend_AOPProxy_Development::storeObject() expected to be a reference, value given in


Related issues

Related to TYPO3.Flow - Bug #30914: Proxy methods for methods with "by reference" return type are brokenResolvedChristian Müller2011-10-14

Actions
#1

Updated by Robert Lemke almost 10 years ago

  • Category set to AOP
  • Status changed from New to Accepted
  • Assignee set to Robert Lemke
  • Target version set to 1.0 beta 1
#2

Updated by Sebastian Kurfuerst over 9 years ago

  • Target version changed from 1.0 beta 1 to 1.0 beta 2

what's the status here? Moving to beta2.

#3

Updated by Robert Lemke over 9 years ago

  • Target version changed from 1.0 beta 2 to 1.0.0
#4

Updated by Karsten Dambekalns over 9 years ago

  • Target version deleted (1.0.0)
#6

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9651

#7

Updated by Christian Müller almost 9 years ago

  • Assignee changed from Robert Lemke to Christian Müller
  • Has patch set to No
#8

Updated by Christian Müller almost 9 years ago

  • Target version set to 1.0.4
#9

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9651

#10

Updated by Christian Müller almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#11

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/10248

#12

Updated by Karsten Dambekalns almost 9 years ago

  • Target version changed from 1.0.4 to 1.0.5
#13

Updated by Karsten Dambekalns over 8 years ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF