Bug #13333
AOP for methods with references do not work.
100%
Description
Tried to log a method call to GenericPod\Backend->storeObject (fourth parameter is a reference to an array)
// // /** // * logging // * // * @param \F3\FLOW3\AOP\JoinPointInterface $joinPoint The current join point // * @return void // * @around method(F3\FLOW3\Persistence\Backend\GenericPdo\Backend->storeObject()) // */ // public function logStoreObject(\F3\FLOW3\AOP\JoinPointInterface $joinPoint) // { // $object = $joinPoint->getMethodArgument('object'); // $id = $joinPoint->getMethodArgument('identifier'); // $parent = $joinPoint->getMethodArgument('parentIdentifier'); // $data = $joinPoint->getMethodArgument('objectData'); // // $this->logger->log('GenericPDOBackend->storeObject(['.get_class($object).'], '.$id.', '.$parent.', ...)'); // // $result = $joinPoint->getAdviceChain()->proceed($joinPoint); // return $result; // }
error/exception:
Warning: Parameter 4 to F3\FLOW3\Persistence\Backend\GenericPdo\Backend_AOPProxy_Development::storeObject() expected to be a reference, value given in
Related issues
Updated by Robert Lemke almost 10 years ago
- Category set to AOP
- Status changed from New to Accepted
- Assignee set to Robert Lemke
- Target version set to 1.0 beta 1
Updated by Sebastian Kurfuerst over 9 years ago
- Target version changed from 1.0 beta 1 to 1.0 beta 2
what's the status here? Moving to beta2.
Updated by Gerrit Code Review almost 9 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9651
Updated by Christian Müller almost 9 years ago
- Assignee changed from Robert Lemke to Christian Müller
- Has patch set to No
Updated by Gerrit Code Review almost 9 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9651
Updated by Christian Müller almost 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset fa0867857380f9d843a2d749d3dd4195f5a6535e.
Updated by Gerrit Code Review almost 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/10248