Support #13468

Document the policy of reviews and submittion

Added by Ernesto Baschny over 8 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Must have
Category:
Documentation
Target version:
-
Start date:
2011-03-01
Due date:
% Done:

0%


Description

We need to document the policy of "Submit" to v4 Core. My suggestion:

Gerrit allows reviewing of patches through a Web UI (http://review.typo3.org). A patch can get:

  • Verified:
    • +1: Code works by testing
    • 0: Have not tested
    • -1: Fails
  • Code Review:
    • +2: Approved
    • +1: Could commit, needs more approval
    • 0: No opinion, just adding some comment
    • -1: Please do not commit
    • -2: Veto

Note that "+1" + "+1" is not equals "+2". The +1 is only kind of a "Like it" button, which multiple people can hit (even anonymous reviewers). Only a core developer can ultimately give a +2, approving a change and unlocking the "Submit" button.

We will use the same policy that we used in the core mailing lists, which is:

A patch needs:

  • 2 reviews by reading, one of them being a core developer
  • 2 reviews by testing, one of them being a core developer

Translating this to Gerrit, this means:

  • Verify:
    • Needs two +1, one of them being a core developer
  • Code Review:
    • First one reviewing and liking it, gives a "+1" (regardless if it is a core developer)
    • Next reviewer gives "+1" if she is a regular reviewer. If its a core developer, he can give a "+2" right away.

As soon as the patch has reached the approved status, one core developer can decide to push the "Submit" button, finally pushing it to the repository.


Related issues

Related to git.typo3.org - Bug #13557: Gerrit does not reflect the "Verified" state according to v4 core team rules Closed 2011-03-02

History

#1 Updated by Xavier Perseguers over 8 years ago

Question: as it is possible de differentiate who wrote the patch and who committed it, do we want to force that whenever a core dev wrote the patch, some other core dev should commit it eventually?

#2 Updated by Ernesto Baschny over 8 years ago

Xavier, I would say the same rules apply for patches by core team members (two further reviews by testing and two by reading, one of them each by a core developer).

Since the author of a patch (the one that originally pulled the change to Gerrit) is recorded anyway when the patch is finally committed to core, it doesn't matter who exactly pushes the "Submit" button. The second core developer, if the patch has enough reviews already, could do it.

The one that hits the "Submit" only has the job / responsibility to make sure that the change passed the approval by the defined rules.

#3 Updated by Ernesto Baschny over 8 years ago

  • Assignee set to Ernesto Baschny

#4 Updated by Ernesto Baschny over 8 years ago

Added first draft of the policy in Wiki:

http://wiki.typo3.org/Gerrit_Review_Workflow

also linked here:

http://wiki.typo3.org/Git_Gerrit

#5 Updated by Ernesto Baschny over 8 years ago

  • Status changed from New to Needs Feedback

#6 Updated by Ernesto Baschny over 8 years ago

  • Status changed from Needs Feedback to Resolved

#7 Updated by Steffen Gebert over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF