http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692005-04-09T17:50:19ZTYPO3 ForgeTYPO3 Core - Bug #14655: require_once() instead of require() should be used in entry scriptshttp://forge.typo3.org/issues/14655?journal_id=374032005-04-09T17:50:19ZRupert Germannrupert.germann@noerdisch.de
<ul></ul><p>hey, seems that my search for the mysterious "Cannot redeclare class t3lib_div..." error when e-accelerator is enabled has an end. Could this have the same reason ? I'll try.</p> TYPO3 Core - Bug #14655: require_once() instead of require() should be used in entry scriptshttp://forge.typo3.org/issues/14655?journal_id=374042005-04-09T18:02:11ZRupert Germannrupert.germann@noerdisch.de
<ul></ul><p>it <em>was</em> the reason !<br />I replaced all (4) occurances of require with require_once in index_ts.php and my sites are accelerated again.<br />thx ingo ;-)</p> TYPO3 Core - Bug #14655: require_once() instead of require() should be used in entry scriptshttp://forge.typo3.org/issues/14655?journal_id=374052005-04-10T18:57:58ZIngmar Schlechtingmar@typo3.org
<ul></ul><p>I checked the following files:<br /> - index_ts.php<br /> - showpic.php<br /> - typo3/thumbs.php<br /> - typo3/init.php<br /> - ext/direct_mail/mod/dmailerd.phpcron</p>
<p>And it turned out that only tumbs.php, index_ts.php and dmailerd.phpcron needed a fix (see attached patches).</p>
<p>Since these fixes don't cause any harm, I see no problem in making the change.</p> TYPO3 Core - Bug #14655: require_once() instead of require() should be used in entry scriptshttp://forge.typo3.org/issues/14655?journal_id=374062005-04-13T13:02:22ZKarsten Dambekalnskarsten@typo3.org
<ul></ul><p>I now have a similar problem - when using require_once it seems as if PHP checks for identical files by using the filename. Now when I includes e.g. t3lib_div with an absolute path <strong>and</strong> with a relative path, I get a fatal error about redeclaring class t3lib_div.<br />This seems to be a bug/design flaw in PHP, though. It might explain some strange results...</p> TYPO3 Core - Bug #14655: require_once() instead of require() should be used in entry scriptshttp://forge.typo3.org/issues/14655?journal_id=374072005-04-13T13:46:58ZKarsten Dambekalnskarsten@typo3.org
<ul></ul><p>The changes are indeed risk-less, I applied the patches to the core files. I have no access to the direct mail CVS, though. Who could apply the changes there?</p>
<p>@Ingmar: Any specific reason why you didn't look a returnmail.phpsh in direct mail as well?</p> TYPO3 Core - Bug #14655: require_once() instead of require() should be used in entry scriptshttp://forge.typo3.org/issues/14655?journal_id=374082005-04-13T14:06:50ZIngmar Schlechtingmar@typo3.org
<ul></ul><p>Assigned to Jan-Erik Revsbech so he can commit dmailerd.phpcron.patch and returnmail.phpsh.patch.</p> TYPO3 Core - Bug #14655: require_once() instead of require() should be used in entry scriptshttp://forge.typo3.org/issues/14655?journal_id=374092005-04-13T14:08:58ZMichael Stuckimichael.stucki@typo3.org
<ul></ul><p>Ingmar, did you look at your change?</p>
<p>-require_once (PATH_t3lib."class.t3lib_readmail.php");<br />+require_once_once (PATH_t3lib."class.t3lib_readmail.php");</p>
<p>I don't believe that this was intended.</p>
<p>PS: Whenever changing such files we should get used to replace the double with single quotes.</p> TYPO3 Core - Bug #14655: require_once() instead of require() should be used in entry scriptshttp://forge.typo3.org/issues/14655?journal_id=374102005-04-13T15:04:08ZJan-Erik Revsbechjanerik@moc.net
<ul></ul><p>Fixed it in dmailerd.phpcron and returnmail.phpsh. Still does not have TER password, so only fixed in CVS.</p> TYPO3 Core - Bug #14655: require_once() instead of require() should be used in entry scriptshttp://forge.typo3.org/issues/14655?journal_id=374112005-04-18T13:38:08ZMichael Stuckimichael.stucki@typo3.org
<ul></ul><p>This can be closed, right? Ingmar, can you please check?</p> TYPO3 Core - Bug #14655: require_once() instead of require() should be used in entry scriptshttp://forge.typo3.org/issues/14655?journal_id=374122005-04-18T15:56:36ZIngmar Schlechtingmar@typo3.org
<ul></ul><p>Yes, this bug can be closed/marked as resolved. (I hope the CVS version of direct_mail is included in 3.8.0b2)</p> TYPO3 Core - Bug #14655: require_once() instead of require() should be used in entry scriptshttp://forge.typo3.org/issues/14655?journal_id=374132005-04-18T17:08:14ZMichael Stuckimichael.stucki@typo3.org
<ul></ul><p>Yes it is.</p>