http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692007-09-25T17:11:12ZTYPO3 ForgeTYPO3 Core - Task #17626: JS-function checkSubmit should not use evalhttp://forge.typo3.org/issues/17626?journal_id=459972007-09-25T17:11:12ZOliver Haderoliver.hader@typo3.org
<ul></ul><p>Hi,<br />what do you mean with "abort the submit in your own javascript-code"? Could you please give an example?<br />We cound integrate another check before line 266, e.g.<br /><pre>
if (STOP) {
return false;
}
</pre><br />So, you can add e.g. the following to t3lib_TCEforms->additionalJS_submit:<br /><pre>
if (!MyValidatorObject.someFunction()) {
STOP = true;
}
</pre></p> TYPO3 Core - Task #17626: JS-function checkSubmit should not use evalhttp://forge.typo3.org/issues/17626?journal_id=459982007-09-25T22:07:07ZMads Brunnmads@typoconsult.dk
<ul></ul><p>Hi,</p>
<p>Yes, that's exactly what I had in mind.</p>
<p>I want e.g. to do a check on a specific field and if it doesn't have a specific value the submit should be aborted.</p>
<p>Btw. I think this used to work in version 4.0 but back then the code in t3lib_TCEforms->additionalJS_submit was simply injected directly in the onsubmit function.</p> TYPO3 Core - Task #17626: JS-function checkSubmit should not use evalhttp://forge.typo3.org/issues/17626?journal_id=851422011-09-04T23:36:39ZAndreas Wolfandreas.wolf@typo3.org
<ul><li><strong>Tracker</strong> changed from <i>Bug</i> to <i>Feature</i></li><li><strong>Subject</strong> changed from <i>JS-function checkSubmit not correctly implemented</i> to <i>JS-function checkSubmit should not use eval</i></li><li><strong>Category</strong> set to <i>FormEngine aka TCEforms</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Accepted</i></li><li><strong>Assignee</strong> set to <i>Andreas Wolf</i></li><li><strong>Target version</strong> deleted (<del><i>0</i></del>)</li></ul><p>I guess this is more a feature than a bug... But we should definitely have it.</p> TYPO3 Core - Task #17626: JS-function checkSubmit should not use evalhttp://forge.typo3.org/issues/17626?journal_id=2415652014-12-18T13:18:32ZMathias Schreibermathias.schreiber@typo3.com
<ul><li><strong>Assignee</strong> changed from <i>Andreas Wolf</i> to <i>Frank Nägler</i></li></ul><p>Could you check during your FormEngine crusade, please?</p> TYPO3 Core - Task #17626: JS-function checkSubmit should not use evalhttp://forge.typo3.org/issues/17626?journal_id=2666922015-07-17T13:25:28ZFrank Näglerfrank.naegler@typo3.org
<ul><li><strong>Target version</strong> set to <i>7.4 (Backend)</i></li><li><strong>PHP Version</strong> deleted (<del><i>4.3</i></del>)</li></ul> TYPO3 Core - Task #17626: JS-function checkSubmit should not use evalhttp://forge.typo3.org/issues/17626?journal_id=2699612015-08-05T10:31:03ZSusanne Moogsusanne.moog@typo3.org
<ul><li><strong>Target version</strong> changed from <i>7.4 (Backend)</i> to <i>7.5</i></li></ul> TYPO3 Core - Task #17626: JS-function checkSubmit should not use evalhttp://forge.typo3.org/issues/17626?journal_id=2779242015-09-24T20:36:49ZBenni Mackbenni@typo3.org
<ul><li><strong>Target version</strong> changed from <i>7.5</i> to <i>7 LTS</i></li></ul> TYPO3 Core - Task #17626: JS-function checkSubmit should not use evalhttp://forge.typo3.org/issues/17626?journal_id=2793322015-10-02T16:44:21ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>Accepted</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/43743">http://review.typo3.org/43743</a></p> TYPO3 Core - Task #17626: JS-function checkSubmit should not use evalhttp://forge.typo3.org/issues/17626?journal_id=2798632015-10-06T09:11:39ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/43743">http://review.typo3.org/43743</a></p> TYPO3 Core - Task #17626: JS-function checkSubmit should not use evalhttp://forge.typo3.org/issues/17626?journal_id=2798642015-10-06T09:11:59ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/43743">http://review.typo3.org/43743</a></p> TYPO3 Core - Task #17626: JS-function checkSubmit should not use evalhttp://forge.typo3.org/issues/17626?journal_id=2801032015-10-06T22:51:02ZBenni Mackbenni@typo3.org
<ul><li><strong>Tracker</strong> changed from <i>Feature</i> to <i>Task</i></li></ul> TYPO3 Core - Task #17626: JS-function checkSubmit should not use evalhttp://forge.typo3.org/issues/17626?journal_id=2808792015-10-10T00:25:59ZGerrit Code Review
<ul></ul><p>Patch set 4 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/43743">http://review.typo3.org/43743</a></p> TYPO3 Core - Task #17626: JS-function checkSubmit should not use evalhttp://forge.typo3.org/issues/17626?journal_id=2827162015-10-23T10:30:12ZFrank Näglerfrank.naegler@typo3.org
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="[TASK] Implement stop functionality to additionalJS_submit Using the hook in JS is not possible ..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/00f93bdfce63210ff3aa7fe762fb4c6e3f6a17d5">00f93bdfce63210ff3aa7fe762fb4c6e3f6a17d5</a>.</p> TYPO3 Core - Task #17626: JS-function checkSubmit should not use evalhttp://forge.typo3.org/issues/17626?journal_id=3464002017-10-21T17:44:57ZRiccardo De Contardierredeco@gmail.com
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>