Bug #21148
closed
Permanent login checkbox is not shown as expected
Added by Stefan Froemken over 14 years ago.
Updated over 5 years ago.
Description
If $GLOBALS['TYPO3_CONF_VARS']['FE']['permalogin'] is set to 2 and $GLOBALS['TYPO3_CONF_VARS']['FE']['lifetime'] is greater than 0, then no checkbox for permalogin appears.
$GLOBALS['TYPO3_CONF_VARS']['FE']['permalogin'] = 2 means: Permanent login is forced to be enabled
In class.tx_felogin_pi1.php I found this:
if (($this->conf['showPermaLogin']) && ($GLOBALS['TYPO3_CONF_VARS']['FE']['permalogin'] 0 || $GLOBALS['TYPO3_CONF_VARS']['FE']['permalogin'] 1) && $GLOBALS['TYPO3_CONF_VARS']['FE']['lifetime'] > 0) {
on line 496
but there is no IF for permalogin = 2!
(issue imported from #M12072)
Files
Actually, there is a bug there. Permanent login should be activated in localconf.php:
(according to config_default.php):
// -1: Permanent login for FE users disabled
// 0: By default permalogin is disabled for FE users but can be enabled by a form control in the login form
// 1: Permanent login is by default enabled but can be disabled by a form control in the login form
// 2: Permanent login is forced to be enabled: Nothing to do
In addition lifetime should be greater than 0 (value in sec).
value 1 does not make sense as it is not possible to deactivate the login. Instead I propose to change its definition so that 0 = disabled but can be enabled by a form control, and 1 = may be globally activated or activated using a form control
Actually, value 2 means the frontend cookie is always active for "lifetime". Those values are not meant to activate or deactivate the "show" of the checkbox in frontend but to tell how should the fe cookie be created. I misunderstood it and will provide a new patch soon.
Committed v3 to trunk (changeset 6646)
Committed v3 to branch 4-3 (changeset 6647)
Ingo, please report if I should commit the change to branch 4-2 as well. Thanks
Btw, great bug report title.
Committed v3 to branch 4-2 (changeset 6665) after clearing bugfix policy with Ingmar
- Status changed from Resolved to Closed
Also available in: Atom
PDF