http://forge.typo3.org/
http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?1705866169
2009-12-13T14:29:40Z
TYPO3 Forge
TYPO3 Core - Feature #21302: click enlarge: popup window params are hardcoded
http://forge.typo3.org/issues/21302?journal_id=53681
2009-12-13T14:29:40Z
Valery Romanchev
romanchev@ttlab.ru
<ul></ul><p>related to <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: The "click-to-enlarge" function of the image content element does not provide scrollbars to the n... (Closed)" href="http://forge.typo3.org/issues/16641">#16641</a></p>
TYPO3 Core - Feature #21302: click enlarge: popup window params are hardcoded
http://forge.typo3.org/issues/21302?journal_id=162504
2013-05-03T14:41:30Z
Alexander Opitz
opitz.alexander@googlemail.com
<ul><li><strong>Category</strong> deleted (<del><i>Communication</i></del>)</li><li><strong>Status</strong> changed from <i>New</i> to <i>Needs Feedback</i></li><li><strong>Target version</strong> deleted (<del><i>0</i></del>)</li></ul><p>The issue is very old, does this issue exists in newer versions of TYPO3 CMS (4.5 or 6.1)?</p>
TYPO3 Core - Feature #21302: click enlarge: popup window params are hardcoded
http://forge.typo3.org/issues/21302?journal_id=162623
2013-05-03T20:39:44Z
Tobias Schmidt
<ul></ul><p>This issue still exists in TYPO3 4.5. In sysext\cms\tslib\class.tslib_content.php, lines 1498 - 1502, it is not possible to insert something like "scrollbars=yes" via TypoScript. The parameters are hardcoded.</p>
TYPO3 Core - Feature #21302: click enlarge: popup window params are hardcoded
http://forge.typo3.org/issues/21302?journal_id=165148
2013-05-14T11:16:24Z
Alexander Opitz
opitz.alexander@googlemail.com
<ul><li><strong>Status</strong> changed from <i>Needs Feedback</i> to <i>New</i></li></ul>
TYPO3 Core - Feature #21302: click enlarge: popup window params are hardcoded
http://forge.typo3.org/issues/21302?journal_id=245059
2015-01-16T17:28:34Z
Mathias Schreiber
mathias.schreiber@typo3.com
<ul><li><strong>Target version</strong> set to <i>7.2 (Frontend)</i></li></ul>
TYPO3 Core - Feature #21302: click enlarge: popup window params are hardcoded
http://forge.typo3.org/issues/21302?journal_id=261933
2015-06-15T18:12:03Z
Benni Mack
benni@typo3.org
<ul><li><strong>Target version</strong> changed from <i>7.2 (Frontend)</i> to <i>7.4 (Backend)</i></li></ul>
TYPO3 Core - Feature #21302: click enlarge: popup window params are hardcoded
http://forge.typo3.org/issues/21302?journal_id=269996
2015-08-05T10:31:19Z
Susanne Moog
susanne.moog@typo3.org
<ul><li><strong>Target version</strong> changed from <i>7.4 (Backend)</i> to <i>7.5</i></li></ul>
TYPO3 Core - Feature #21302: click enlarge: popup window params are hardcoded
http://forge.typo3.org/issues/21302?journal_id=277845
2015-09-24T20:31:12Z
Benni Mack
benni@typo3.org
<ul><li><strong>Target version</strong> deleted (<del><i>7.5</i></del>)</li></ul>
TYPO3 Core - Feature #21302: click enlarge: popup window params are hardcoded
http://forge.typo3.org/issues/21302?journal_id=310138
2016-07-21T09:58:11Z
Riccardo De Contardi
erredeco@gmail.com
<ul><li><strong>Category</strong> set to <i>Frontend</i></li></ul>
TYPO3 Core - Feature #21302: click enlarge: popup window params are hardcoded
http://forge.typo3.org/issues/21302?journal_id=368377
2018-07-05T23:25:12Z
Riccardo De Contardi
erredeco@gmail.com
<ul></ul><p>Actually, you <em>can</em> add parameters to the popup using typoscript, with <code>JSwindow_params</code></p>
<p>See documentation here:</p>
<p><a class="external" href="https://docs.typo3.org/typo3cms/TyposcriptReference/Functions/Typolink/Index.html#jswindow-params">https://docs.typo3.org/typo3cms/TyposcriptReference/Functions/Typolink/Index.html#jswindow-params</a></p>
<p>example:</p>
<pre>
page=PAGE
page.60=TEXT
page.60.value=hello world
page.60.typolink.parameter = 507 400x300
page.60.typolink.JSwindow_params=scrollbars=1,resizable=0,toolbar=0,status=0
page.60.wrap=<p>|</p>
</pre>
<p>The only "hardcoded" parameter seems to be the name "FEopenLink" - see <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: popupwindows have hardcoded window-name FEopenLink (Closed)" href="http://forge.typo3.org/issues/31636">#31636</a>.</p>
<p><strong>By the way</strong></p>
<p>Modern browsers like Chrome or Firefox ignore the parameter <code>resizable=0</code> ;)</p>
TYPO3 Core - Feature #21302: click enlarge: popup window params are hardcoded
http://forge.typo3.org/issues/21302?journal_id=368378
2018-07-06T00:27:46Z
Tobias Schmidt
<ul></ul><p>I'm not 100% sure but I think the TypoScript settings for <code>JSwindow_params</code> don't apply to the <em>click enlarge</em> context. In TYPO3 v8.7 the source code in method <code>imageLinkWrap</code> of class <code>\TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer</code> (lines 1468 - 1478) is basically the same as it was in TYPO3 v4.5:</p>
<pre><code class="php syntaxhl" data-language="php"><span class="nv">$onClick</span> <span class="o">=</span> <span class="s1">'openPic('</span>
<span class="mf">.</span> <span class="nc">GeneralUtility</span><span class="o">::</span><span class="nf">quoteJSvalue</span><span class="p">(</span><span class="nv">$this</span><span class="o">-></span><span class="nf">getTypoScriptFrontendController</span><span class="p">()</span><span class="o">-></span><span class="nf">baseUrlWrap</span><span class="p">(</span><span class="nv">$url</span><span class="p">))</span> <span class="mf">.</span> <span class="s1">','</span>
<span class="mf">.</span> <span class="s1">'\''</span> <span class="mf">.</span> <span class="p">(</span><span class="nv">$newWindow</span> <span class="o">?</span> <span class="nb">md5</span><span class="p">(</span><span class="nv">$url</span><span class="p">)</span> <span class="o">:</span> <span class="s1">'thePicture'</span><span class="p">)</span> <span class="mf">.</span> <span class="s1">'\','</span>
<span class="mf">.</span> <span class="nc">GeneralUtility</span><span class="o">::</span><span class="nf">quoteJSvalue</span><span class="p">(</span><span class="s1">'width='</span> <span class="mf">.</span> <span class="p">(</span><span class="nv">$processedFile</span><span class="o">-></span><span class="nf">getProperty</span><span class="p">(</span><span class="s1">'width'</span><span class="p">)</span> <span class="o">+</span> <span class="nv">$offset</span><span class="p">[</span><span class="mi">0</span><span class="p">])</span>
<span class="mf">.</span> <span class="s1">',height='</span> <span class="mf">.</span> <span class="p">(</span><span class="nv">$processedFile</span><span class="o">-></span><span class="nf">getProperty</span><span class="p">(</span><span class="s1">'height'</span><span class="p">)</span> <span class="o">+</span> <span class="nv">$offset</span><span class="p">[</span><span class="mi">1</span><span class="p">])</span> <span class="mf">.</span> <span class="s1">',status=0,menubar=0'</span><span class="p">)</span>
<span class="mf">.</span> <span class="s1">'); return false;'</span><span class="p">;</span>
<span class="nv">$a1</span> <span class="o">=</span> <span class="s1">'<a href="'</span> <span class="mf">.</span> <span class="nb">htmlspecialchars</span><span class="p">(</span><span class="nv">$url</span><span class="p">)</span> <span class="mf">.</span> <span class="s1">'"'</span>
<span class="mf">.</span> <span class="s1">' onclick="'</span> <span class="mf">.</span> <span class="nb">htmlspecialchars</span><span class="p">(</span><span class="nv">$onClick</span><span class="p">)</span> <span class="mf">.</span> <span class="s1">'"'</span>
<span class="mf">.</span> <span class="p">(</span><span class="nv">$target</span> <span class="o">!==</span> <span class="s1">''</span> <span class="o">?</span> <span class="s1">' target="'</span> <span class="mf">.</span> <span class="nb">htmlspecialchars</span><span class="p">(</span><span class="nv">$target</span><span class="p">)</span> <span class="mf">.</span> <span class="s1">'"'</span> <span class="o">:</span> <span class="s1">''</span><span class="p">)</span>
<span class="mf">.</span> <span class="nv">$this</span><span class="o">-></span><span class="nf">getTypoScriptFrontendController</span><span class="p">()</span><span class="o">-></span><span class="nc">ATagParams</span> <span class="mf">.</span> <span class="s1">'>'</span><span class="p">;</span>
<span class="nv">$a2</span> <span class="o">=</span> <span class="s1">'</a>'</span><span class="p">;</span>
</code></pre>
<p>Some attributes and values are hard coded. Adding custom attributes is not possible.</p>
TYPO3 Core - Feature #21302: click enlarge: popup window params are hardcoded
http://forge.typo3.org/issues/21302?journal_id=368713
2018-07-12T09:27:07Z
Riccardo De Contardi
erredeco@gmail.com
<ul></ul><p>@Tobias Schmidt good point. Thank you for your findings</p>
TYPO3 Core - Feature #21302: click enlarge: popup window params are hardcoded
http://forge.typo3.org/issues/21302?journal_id=420596
2020-03-25T20:27:26Z
Gerrit Code Review
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/63921">https://review.typo3.org/c/Packages/TYPO3.CMS/+/63921</a></p>
TYPO3 Core - Feature #21302: click enlarge: popup window params are hardcoded
http://forge.typo3.org/issues/21302?journal_id=420629
2020-03-26T07:13:14Z
Gerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/63921">https://review.typo3.org/c/Packages/TYPO3.CMS/+/63921</a></p>
TYPO3 Core - Feature #21302: click enlarge: popup window params are hardcoded
http://forge.typo3.org/issues/21302?journal_id=420761
2020-03-26T18:30:05Z
Benni Mack
benni@typo3.org
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="[BUGFIX] Ensure to override JSwindow custom parameters Currently "typolink.JSwindow_params" allo..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/95f94f80e36eabbd9334a0cf48259910b8b7bd37">95f94f80e36eabbd9334a0cf48259910b8b7bd37</a>.</p>
TYPO3 Core - Feature #21302: click enlarge: popup window params are hardcoded
http://forge.typo3.org/issues/21302?journal_id=423513
2020-04-21T12:16:08Z
Benni Mack
benni@typo3.org
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>