Project

General

Profile

Actions

Bug #23272

closed

Incorrect backpath used when including default and skin stylesheets

Added by Jeff Segars over 13 years ago. Updated about 10 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2010-07-26
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

CSS paths in typo3/template.php are currently calculated using $GLOBALS['BACK_PATH']. Elsewhere in t3lib_tceforms, $this->backPath is used instead of $GLOBALS['BACK_PATH]. $GLOBALS['BACK_PATH'] may not be available in all contexts, leading to missing styles.

The issue can easily be seen in frontend editing, where the CSS for sprite images is not loaded due to the incorrect path. In this instance $this->backPath is set properly and used elsewhere in t3lib_tceforms but $GLOBALS['BACK_PATH'] is not.

In previous versions of TYPO3, $this->backPath was not set at all in the backend context because all of the views were directly inside /typo3/ and no back path was needed. After moving list view and other modules to extensions, a back path is needed so the first hunk in this patch sets $this->backPath to $GLOBALS['BACK_PATH'] in the normal backend context. While its related to this patch, it could also be a followup to RFCs 15149-15155.

(issue imported from #M15242)


Files

15242.diff (1.93 KB) 15242.diff Administrator Admin, 2010-07-26 22:51
15242_v2.diff (2.17 KB) 15242_v2.diff Administrator Admin, 2010-07-27 18:14
Actions #1

Updated by Björn Pedersen over 13 years ago

v2 at least gives the date picker back again. The icons are still either missing or replaced by a questionmark on red background.

Actions #2

Updated by Jeff Segars over 13 years ago

Yes, that is a separate issue that will need to be addressed by feeditadvanced. See http://forge.typo3.org/issues/8072 for a preliminary patch to bring these icons back.

Thanks for testing!

Actions #3

Updated by Jeff Segars over 13 years ago

Björn, just FYI, i have now committed the feeditadvanced portion of the patch so the sprite icons should be working as expected when you use the latest dev version of feeditadvanced in conjunction with this patch.

Actions #4

Updated by Jeff Segars over 13 years ago

On second thought, this is actually more complicated than my patch. There are plenty of places in the core where the backPath is set outside the constructor and this patch would potentially impact them.

For now, I'll just address it in feeditadvanced by setting $GLOBALS['BACK_PATH'] on my own.

Actions #5

Updated by Alexander Opitz over 10 years ago

  • Status changed from Accepted to Needs Feedback
  • Target version deleted (0)
  • Is Regression set to No

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (4.5 or 6.1)?

Actions #6

Updated by Alexander Opitz about 10 years ago

  • Status changed from Needs Feedback to Closed
  • Assignee deleted (Jeff Segars)

No feedback within the last 90 days => closing this ticket.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

Actions

Also available in: Atom PDF