Bug #24295

Live-Search: Taking focus from search field should show tooltip "Enter search term" again

Added by Chris topher about 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2010-12-05
Due date:
% Done:

0%

TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When you once clicked in the Search field and then leave it again, the Tooltip should reappear.

(issue imported from #M16681)

16681.diff View (3.24 KB) Administrator Admin, 2010-12-27 18:58

16681_v2.diff View (2.08 KB) Administrator Admin, 2011-01-18 22:22

16681_v3.diff View (2.17 KB) Administrator Admin, 2011-01-19 22:53

16681_v5.diff View (3.84 KB) Administrator Admin, 2011-01-22 17:14


Related issues

Related to TYPO3 Core - Feature #24092: Add live search to the backend toolbar Closed 2010-11-17
Related to TYPO3 Core - Bug #24721: Live-Search help only appearing at first use Closed 2011-01-22

History

#1 Updated by Jeff Segars about 9 years ago

Thanks for the bug report! I'd say this should only be the case when the there is no search term. If there is a search term, then it stays in place until the clearing button is clicked.

#2 Updated by Jeff Segars about 9 years ago

Attached patch fixes this issue by reworking the click handling inside the iFrame.

#3 Updated by Jeff Segars about 9 years ago

Committed to trunk in r9923.

#4 Updated by Chris topher about 9 years ago

Hi Jeff,

thanks for your patch. You are right in saying that the tooltip should only reappear, if the field is empty. ;-)
The patch works great, when I click into the darkest part of the topbar to take the focus away.

But when I click somewhere else (e.g. in the second darkest line at the top or into an open TCEform), the tooltip still is not shown. :-(
Do you think, this is also fixable?

#5 Updated by Jeff Segars about 9 years ago

Hey Christopher,
The scenario you describe is actually the one that the patch attempted to address, albeit not that well.

In looking against, I think I see the issue. When the backend first loads, you can click anywhere in the backend and see the default text come back again. Once a new iFrame is loaded (such as TCEForms) there is not an event listener on that new IFrame to handle the click.

I'll need to think a bit about the best way to handle that.

Thanks,
Jeff

#6 Updated by Jeff Segars about 9 years ago

Just uploaded a v2 patch which should fix this permanently. Let me know if you have any feedback and I'll get it on the core list as soon as possible.

Thanks,
Jeff

#7 Updated by Steffen Gebert about 9 years ago

Christopher?

#8 Updated by Chris topher about 9 years ago

Steffen!

I tested v2 and the tooltip is shown correctly with it.

Only the textcolor is not right, when you put the focus to the grey part of the BE (it is black instead of grey), but Steffen already noted this in #24652, so nothing to worry about here.

So: Version 2 works correctly!

#9 Updated by Jeff Segars about 9 years ago

Yes, I noticed this text color issue as well. It has to do with a class for the default value not being applied when the text is reset. Going to do a little more investigation there before putting it on the core list this afternoon.

Thanks for testing!

#10 Updated by Jeff Segars about 9 years ago

v3 patch fixes the text color by specifying that the live search no longer has focus.

#11 Updated by Ingo Renner about 9 years ago

committed to trunk (4.5) in r10262

#12 Updated by Susanne Moog almost 9 years ago

  • Target version deleted (4.5.0)

Also available in: Atom PDF