Task #25886
Clean up Request hierarchy and fix type hints
100%
Description
Currently we a hierarchy around RequestInterface like this:
RequestInterface + Request | + Web\Request | + Web\SubRequest + CLI\Request
This could be simplified by getting rid of Request
and combining it into Web\Request
.
Another issue are type hints. Some places say they return RequestInterface
(e.g. the ControllerContext
). This potentially leads to trouble, if one assumes Request
is returned, as that has some methods not defined in RequestInterface
.
Updated by Karsten Dambekalns over 9 years ago
- Status changed from New to Accepted
- Assignee set to Karsten Dambekalns
Updated by Karsten Dambekalns over 9 years ago
- Status changed from Accepted to Under Review
A first change about cleaning up the hierarchy is up for review now.
Updated by Mr. Hudson over 9 years ago
Patch set 2 of change If8bb5f383f9204f9f7638292f6680ba86aca846b has been pushed to the review server.
It is available at http://review.typo3.org/3067
Updated by Karsten Dambekalns over 9 years ago
Karsten Dambekalns wrote:
A first change about cleaning up the hierarchy is up for review now.
Seems all fine, no changes needed.
Updated by Mr. Hudson over 9 years ago
Patch set 3 of change If8bb5f383f9204f9f7638292f6680ba86aca846b has been pushed to the review server.
It is available at http://review.typo3.org/3067
Updated by Mr. Hudson over 9 years ago
Patch set 4 of change If8bb5f383f9204f9f7638292f6680ba86aca846b has been pushed to the review server.
It is available at http://review.typo3.org/3067
Updated by Karsten Dambekalns over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 6a35bed37ab036a7fd8f884e01350bff7e230f4f.