Task #27613

Rename $omitSignalInformation to $passSignalInformation

Added by Karsten Dambekalns over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Should have
Category:
SignalSlot
Start date:
2011-06-21
Due date:
% Done:

100%

Estimated time:
Sprint:
PHP Version:
Has patch:
Complexity:

Description

A flag that comes with double negation by default should be avoided, thus we should invert the name and meaning here.

Note: do we actually need this? If we keep it, maybe make the signal information an array, so it's easier to amend in the future? Currently the simple string with classname and method name is a little limited in expressiveness.

#1

Updated by Robert Lemke over 10 years ago

Karsten Dambekalns wrote:

A flag that comes with double negation by default should be avoided, thus we should invert the name and meaning here.

fine, make sure to check our projects for any occurrence ...

Note: do we actually need this? If we keep it, maybe make the signal information an array, so it's easier to amend in the future? Currently the simple string with classname and method name is a little limited in expressiveness.

But what other information could you imagine?

#2

Updated by Karsten Dambekalns over 10 years ago

  • Status changed from Needs Feedback to Accepted

Ok, we'll leave the signal information as is, and only rename the parameter.

#3

Updated by Mr. Hudson over 10 years ago

  • Status changed from Accepted to Under Review

Patch set 1 of change Ie878157242fb76117b27ee9d23a4dda67b4b8d0d has been pushed to the review server.
It is available at http://review.typo3.org/2935

#4

Updated by Mr. Hudson over 10 years ago

Patch set 2 of change Ie878157242fb76117b27ee9d23a4dda67b4b8d0d has been pushed to the review server.
It is available at http://review.typo3.org/2935

#5

Updated by Karsten Dambekalns over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF