Bug #28477

Method visibility filter does not work

Added by Christopher Hlubek about 10 years ago. Updated about 10 years ago.

Status:
Resolved
Priority:
Must have
Category:
AOP
Target version:
-
Start date:
2011-07-26
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
Complexity:

Description

The method visibility filter is not doing anything (again). A wrong regexp match parses visibilities like "public " or "protected ". The check for valid visibilities inside the PointcutMethodNameFilter is uselesss, because it accepts the space behind the visibility.

There is also no real unit test for the parseDesignatorMethod method inside the PointcutExpressionParser and the functional test for protected methods had a wrong visibility (public instead of protected!).

#1

Updated by Mr. Hudson about 10 years ago

  • Status changed from New to Under Review

Patch set 1 of change I66925ef9b482c1d0abe9334740567ced23352fe8 has been pushed to the review server.
It is available at http://review.typo3.org/3726

#2

Updated by Christopher Hlubek about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF