Bug #28487

ActionController ErrorAction forgets SubpackageKey

Added by Torsten no-lastname-given about 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Must have
Category:
MVC
Start date:
2011-07-26
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
Complexity:

Description

The method errorAction of TYPO3\FLOW3\MVC\Controller\ActionController forwards like this:

$this->forward($referringRequest->getControllerActionName(), $referringRequest->getControllerName(), $referringRequest->getControllerPackageKey(), $referringRequest->getArguments());

better would be something like this:

$controllerPackageKey = $referringRequest->getControllerPackageKey();
if ($referringRequest->getControllerSubPackageKey() !== NULL) {
    $controllerPackageKey .= '\\' . $referringRequest->getControllerSubpackageKey();
}

$this->forward($referringRequest->getControllerActionName(), $referringRequest->getControllerName(), $controllerPackageKey, $referringRequest->getArguments());
#1

Updated by Sebastian Kurfuerst almost 10 years ago

  • Target version set to 1.0 beta 2
#2

Updated by Karsten Dambekalns almost 10 years ago

  • Category set to MVC
#3

Updated by Sebastian Kurfuerst almost 10 years ago

  • Status changed from New to Accepted
  • Assignee set to Sebastian Kurfuerst

I'm working on this now.

#4

Updated by Mr. Hudson almost 10 years ago

  • Status changed from Accepted to Under Review

Patch set 1 of change Id4dfaea7d919ba2eb8d031be505d76815927999f has been pushed to the review server.
It is available at http://review.typo3.org/4783

#5

Updated by Mr. Hudson almost 10 years ago

Patch set 2 of change Id4dfaea7d919ba2eb8d031be505d76815927999f has been pushed to the review server.
It is available at http://review.typo3.org/4783

#6

Updated by Sebastian Kurfuerst almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF