Bug #28597

Upgrade wizard "finds" deprecated properties, which are not there

Added by Chris topher almost 8 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Should have
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
-
Start date:
2011-07-30
Due date:
% Done:

100%

TYPO3 Version:
4.6
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The new Upgrade Wizard always tells me
"Some deprecated Page TS Config properties were found. However, the wizard was unable to automatically replace any of the deprecated properties found. They will have to be replaced manually."

I have manually checked the database and I get no hit for one of those properties, which cannot be replaced automatically.

However there is a hit when I search the DB for "fontsize":

RTE.default.showButtons = textcolor, fontstyle, fontsize

I can only imagine that this causes this wrong message.


Related issues

Related to TYPO3 Core - Feature #28325: htmlArea RTE: Deprecate/restructure various RTE configuration properties Closed 2011-07-20

Associated revisions

Revision edeba3c6 (diff)
Added by Stanislas Rolland almost 8 years ago

[BUGFIX] Upgrade wizard incorrectly "finds" deprecated properties

Make the pattern binary.
Do not select the pattern followed by 's' (do not select RTE.fontSizes)
Remove fontSize from properties that are replaced automatically.

Change-Id: I09d07c056eefc8e80b833fc59d99fb08c5e2a9b7
Fixes: #28597
Releases: 4.6
Reviewed-on: http://review.typo3.org/3920
Reviewed-by: Christopher
Tested-by: Christopher
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

History

#1 Updated by Mr. Hudson almost 8 years ago

Patch set 1 of change I41e399fb021d6f178c1a6e4fe616bc5413e0ad04 has been pushed to the review server.
It is available at http://review.typo3.org/3919

#2 Updated by Stanislas Rolland almost 8 years ago

  • Status changed from New to Under Review
  • Assignee set to Stanislas Rolland
  • Target version set to 4.6.0-beta1

#3 Updated by Mr. Hudson almost 8 years ago

Patch set 1 of change I09d07c056eefc8e80b833fc59d99fb08c5e2a9b7 has been pushed to the review server.
It is available at http://review.typo3.org/3920

#4 Updated by Stanislas Rolland almost 8 years ago

I pushed a second version of the patch that will:

Make the pattern binary.

Do not select the pattern followed by 's' (do not select RTE.fontSizes)

Remove fontSize from properties that are replaced automatically.

#5 Updated by Chris topher almost 8 years ago

Patch set 1 partly solves the issue for the following two lines (each of them caused the problem before).

RTE.default.showButtons = textcolor, fontstyle, fontsize, copy, cut, paste, textstylelabel, textstyle, bold, italic, undo, redo, left, center, right, justifyfull, orderedlist, unorderedlist, outdent, indent, link, image, table, removeformat, rowinsertabove, rowinsertunder, rowdelete, columninsertbefore, columninsertafter, columndelete, cellmerge RTE.default.toolbarOrder = cut, copy, paste, bar, undo, redo, bar, table, rowinsertabove, rowinsertunder, rowdelete, columninsertbefore, columninsertafter, columndelete, cellmerge, tableproperties, bar, link, image, bar, textcolor, bar, removeformat, chMode, bar, linebreak, fontstyle, space, fontsize, bar, bold, italic, bar, left, center, right, justifyfull, bar, orderedlist, unorderedlist, bar, outdent, indent

Patch Set 1 solves this part.


However, I still get a false alarm with this line:

RTE.fontSizes { .... }

#6 Updated by Stanislas Rolland almost 8 years ago

Christopher wrote:

However, I still get a false alarm with this line:

> RTE.fontSizes { > .... > } >

Yes. I think this is fixed in the "new" patch set 1: http://review.typo3.org/3920

#7 Updated by Chris topher almost 8 years ago

Stanislas Rolland wrote:

Christopher wrote:

However, I still get a false alarm with this line:
....

Yes. I think this is fixed in the "new" patch set 1.

Yes, it is. It's working correctly now for me.

Thank you!

#8 Updated by Stanislas Rolland almost 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Xavier Perseguers about 7 years ago

  • Status changed from Resolved to Closed

#10 Updated by Ernesto Baschny almost 6 years ago

  • Target version deleted (4.6.0-beta1)

Also available in: Atom PDF