http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692011-08-27T19:51:20ZTYPO3 ForgeTYPO3 Core - Bug #29220: createEncryptionKey always returns key with 96 charactershttp://forge.typo3.org/issues/29220?journal_id=844092011-08-27T19:51:20ZIngmar Schlechtingmar@typo3.org
<ul><li><strong>Assignee</strong> set to <i>Helmut Hummel</i></li></ul><p>@Helmut, could you check it and dispatch the bug to someone in the security team please? Thx in advance!</p> TYPO3 Core - Bug #29220: createEncryptionKey always returns key with 96 charactershttp://forge.typo3.org/issues/29220?journal_id=844402011-08-28T16:48:22ZSteffen Gebertsteffen.gebert@typo3.org
<ul></ul><p>I wouldn't treat this as security issue. It's a normal bug.</p> TYPO3 Core - Bug #29220: createEncryptionKey always returns key with 96 charactershttp://forge.typo3.org/issues/29220?journal_id=848362011-08-30T22:53:07ZSteffen Gebertsteffen.gebert@typo3.org
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Accepted</i></li></ul><p>Confirmed by Unit Test in <a class="issue tracker-4 status-6 priority-4 priority-default closed" title="Task: Add Unit Test for tx_install::createEncryptionKey (Rejected)" href="http://forge.typo3.org/issues/29368">#29368</a></p>
<p>I'm not yet working on a solution (so if sb. else wants to pick this, feel free!). Adrian, could you push a patch to Gerrit? See <a class="external" href="http://wiki.typo3.org/Git">http://wiki.typo3.org/Git</a></p> TYPO3 Core - Bug #29220: createEncryptionKey always returns key with 96 charactershttp://forge.typo3.org/issues/29220?journal_id=848372011-08-30T22:53:27ZSteffen Gebertsteffen.gebert@typo3.org
<ul><li><strong>Parent task</strong> set to <i>#29368</i></li></ul> TYPO3 Core - Bug #29220: createEncryptionKey always returns key with 96 charactershttp://forge.typo3.org/issues/29220?journal_id=848452011-08-31T01:36:28ZHelmut Hummeltypo3@helhum.io
<ul></ul><p>Just use t3lib_div::getRandomHexString() which does exactly that. And there is a code duplication since this method is also used in tx_install_ajax</p>
<p>I would just remove these two methods and replace them with t3lib_div::getRandomHexString(96)</p>
<p>Btw. the method is never called with a different value, so this is indeed a regular cleanup and not security related.</p> TYPO3 Core - Bug #29220: createEncryptionKey always returns key with 96 charactershttp://forge.typo3.org/issues/29220?journal_id=953802011-11-29T22:01:37ZMr. Jenkinsreview@typo3.org
<ul><li><strong>Status</strong> changed from <i>Accepted</i> to <i>Under Review</i></li></ul><p>Patch set 1 of change I666a3620080fd0f5281e899250f5c710e2550173 has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/6989">http://review.typo3.org/6989</a></p> TYPO3 Core - Bug #29220: createEncryptionKey always returns key with 96 charactershttp://forge.typo3.org/issues/29220?journal_id=953842011-11-29T22:18:47ZMr. Jenkinsreview@typo3.org
<ul></ul><p>Patch set 2 of change I666a3620080fd0f5281e899250f5c710e2550173 has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/6989">http://review.typo3.org/6989</a></p> TYPO3 Core - Bug #29220: createEncryptionKey always returns key with 96 charactershttp://forge.typo3.org/issues/29220?journal_id=955562011-11-30T22:38:32ZMr. Jenkinsreview@typo3.org
<ul></ul><p>Patch set 3 of change I666a3620080fd0f5281e899250f5c710e2550173 has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/6989">http://review.typo3.org/6989</a></p> TYPO3 Core - Bug #29220: createEncryptionKey always returns key with 96 charactershttp://forge.typo3.org/issues/29220?journal_id=955572011-11-30T22:42:10ZMr. Jenkinsreview@typo3.org
<ul></ul><p>Patch set 4 of change I666a3620080fd0f5281e899250f5c710e2550173 has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/6989">http://review.typo3.org/6989</a></p> TYPO3 Core - Bug #29220: createEncryptionKey always returns key with 96 charactershttp://forge.typo3.org/issues/29220?journal_id=1011072012-02-01T01:11:19ZSteffen Gebertsteffen.gebert@typo3.org
<ul><li><strong>Parent task</strong> deleted (<del><i>#29368</i></del>)</li></ul> TYPO3 Core - Bug #29220: createEncryptionKey always returns key with 96 charactershttp://forge.typo3.org/issues/29220?journal_id=1217302012-06-28T23:51:31ZGerrit Code Review
<ul></ul><p>Patch set 5 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/6989">http://review.typo3.org/6989</a></p> TYPO3 Core - Bug #29220: createEncryptionKey always returns key with 96 charactershttp://forge.typo3.org/issues/29220?journal_id=1435512012-12-06T09:51:47ZGerrit Code Review
<ul></ul><p>Patch set 6 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/6989">http://review.typo3.org/6989</a></p> TYPO3 Core - Bug #29220: createEncryptionKey always returns key with 96 charactershttp://forge.typo3.org/issues/29220?journal_id=1711422013-06-30T17:23:22ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>TYPO3_6-1</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/21749">https://review.typo3.org/21749</a></p> TYPO3 Core - Bug #29220: createEncryptionKey always returns key with 96 charactershttp://forge.typo3.org/issues/29220?journal_id=1711432013-06-30T17:26:53ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>TYPO3_6-0</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/21750">https://review.typo3.org/21750</a></p> TYPO3 Core - Bug #29220: createEncryptionKey always returns key with 96 charactershttp://forge.typo3.org/issues/29220?journal_id=1711442013-06-30T17:30:27ZMario Rimannmario@rimann.org
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="[TASK] createEncryptionKey always returns key with 96 characters Update the createEncryptionKey ..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/a626339b94368fef6c7fc66d20795a5f054a2b34">a626339b94368fef6c7fc66d20795a5f054a2b34</a>.</p> TYPO3 Core - Bug #29220: createEncryptionKey always returns key with 96 charactershttp://forge.typo3.org/issues/29220?journal_id=3848202018-10-02T12:19:05ZBenni Mackbenni@typo3.org
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>