Bug #30040

Missing quotes in system() command in initializeForRuntime()

Added by Adrian Föder over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Should have
Category:
Core
Start date:
2011-09-19
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
No
Complexity:

Description

As a hardcore Windows user I again experienced a problem regarding the quotes for a system() command, in my case resolving to something like
system('c:\Program Files\Zend.....')

which ended as >> "C:\Program" is not an existing..... <<

so I fixed line 420 of Core/Bootstrap.php; changing from

$command = escapeshellcmd($this->settings['core']['phpBinaryPathAndFilename']) . ' -c ' . escapeshellarg(php_ini_loaded_file()) . ' -v';

...to

$command = '"' . escapeshellcmd($this->settings['core']['phpBinaryPathAndFilename']) . '" -c ' . escapeshellarg(php_ini_loaded_file()) . ' -v';

This works now.


Related issues

Related to TYPO3.Flow - Bug #32827: TYPO3\FLOW3\Exception thrown in file Bootstrap.phpClosedKarsten Dambekalns2011-12-24

Actions
Has duplicate TYPO3.Flow - Bug #31779: Command execution on Windows breaks with special chars in pathClosedBastian Waidelich2011-11-12

Actions
#1

Updated by Karsten Dambekalns over 9 years ago

  • Project changed from TYPO3 Flow Base Distribution to TYPO3.Flow
#2

Updated by Karsten Dambekalns over 9 years ago

  • Category set to Core
  • Assignee set to Bastian Waidelich
  • Target version set to 1.0.1

Bastian can you verify this and create a change?

#3

Updated by Adrian Föder over 9 years ago

I by the way was able to "fix" that with using forward slashes and 8.3 filenames (as noted in http://forge.typo3.org/projects/flow3/wiki/Installation_hints ).
But we should wrap the quotes anyway because it's just correct. (Bastian, maybe you remember, on the T3DD11 I poked you about this issue, you fixed it and... maybe forgot to commit it :)

#4

Updated by Bastian Waidelich over 9 years ago

  • Status changed from New to Accepted
  • Has patch set to No
#5

Updated by Mr. Hudson over 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 of change Ida11468a75ba2465db275a55e331b2d6e6eb4a0f has been pushed to the review server.
It is available at http://review.typo3.org/6663

#6

Updated by Bastian Waidelich over 9 years ago

Please test asap so this can go into the bugfix release 1.0.1 today!

#7

Updated by Mr. Hudson over 9 years ago

Patch set 2 of change Ida11468a75ba2465db275a55e331b2d6e6eb4a0f has been pushed to the review server.
It is available at http://review.typo3.org/6663

#8

Updated by Mr. Hudson over 9 years ago

Patch set 3 of change Ida11468a75ba2465db275a55e331b2d6e6eb4a0f has been pushed to the review server.
It is available at http://review.typo3.org/6663

#9

Updated by Mr. Hudson over 9 years ago

Patch set 4 of change Ida11468a75ba2465db275a55e331b2d6e6eb4a0f has been pushed to the review server.
It is available at http://review.typo3.org/6663

#10

Updated by Bastian Waidelich over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF