http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692011-10-13T12:22:24ZTYPO3 ForgeTYPO3 Core - Bug #30863: t3lib_pagerendererhttp://forge.typo3.org/issues/30863?journal_id=902292011-10-13T12:22:24ZSteffen Gebertsteffen.gebert@typo3.org
<ul><li><strong>Category</strong> set to <i>Backend API</i></li><li><strong>Complexity</strong> set to <i>easy</i></li></ul><p>Got broken with <a class="changeset" title="Follow-up to #15741: Feature: PageRenderer should be able to include locallang-files as JS-Inline..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/5dc1ab28386e7a14c29a60981b2ca87b210da3db">5dc1ab28</a> (a follow-up for <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: "Edit in Rich Text Editor" shows LIVE version (Closed)" href="http://forge.typo3.org/issues/15741">#15741</a>) while copy and pasting (wtf..)</p>
<p>Jens, could you please point out, how to reproduce the bug? At least code-wise it looks obvious.</p> TYPO3 Core - Bug #30863: t3lib_pagerendererhttp://forge.typo3.org/issues/30863?journal_id=902712011-10-13T17:14:09ZJens Wittjwitt@freicom.de
<ul></ul><p>Steffen Gebert wrote:</p>
<blockquote>
<p>Got broken with <a class="changeset" title="Follow-up to #15741: Feature: PageRenderer should be able to include locallang-files as JS-Inline..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/5dc1ab28386e7a14c29a60981b2ca87b210da3db">5dc1ab28</a> (a follow-up for <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: "Edit in Rich Text Editor" shows LIVE version (Closed)" href="http://forge.typo3.org/issues/15741">#15741</a>) while copy and pasting (wtf..)</p>
<p>Jens, could you please point out, how to reproduce the bug? At least code-wise it looks obvious.</p>
</blockquote>
<p>Okay, I had a look at the diff files and saw that you have changed the behavior of this function.<br />But. If you do so $labelPattern and the call off preg_replace are useless and even the parameter $stripFromSelectionName is useless and irritating. So its better to remove it, i think.<br />I prefer the old behaviour. <br />Jens</p> TYPO3 Core - Bug #30863: t3lib_pagerendererhttp://forge.typo3.org/issues/30863?journal_id=903502011-10-14T08:57:53ZJens Wittjwitt@freicom.de
<ul></ul><p>Steffen Gebert wrote:</p>
<blockquote>
<p>Got broken with <a class="changeset" title="Follow-up to #15741: Feature: PageRenderer should be able to include locallang-files as JS-Inline..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/5dc1ab28386e7a14c29a60981b2ca87b210da3db">5dc1ab28</a> (a follow-up for <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: "Edit in Rich Text Editor" shows LIVE version (Closed)" href="http://forge.typo3.org/issues/15741">#15741</a>) while copy and pasting (wtf..)</p>
<p>Jens, could you please point out, how to reproduce the bug? At least code-wise it looks obvious.</p>
</blockquote>
<p>In your Testfile (t3lib_pagerendererTest.php) is the Testcase <br />$this->assertContains('edRecord', $out);<br />in the function<br />"areInlineLanguageLablesSelectedAndStripped() (line 844)" <br />wrong</p>
<p>it must be $this->assertNotContains('lock', $out);</p>
<p>if you will see that the string is stripped.</p>
<p>Jens</p> TYPO3 Core - Bug #30863: t3lib_pagerendererhttp://forge.typo3.org/issues/30863?journal_id=2394672014-12-08T13:32:23ZAlexander Opitzopitz.alexander@googlemail.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Needs Feedback</i></li><li><strong>Is Regression</strong> set to <i>No</i></li></ul><p>Hi,</p>
<p>as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (6.2.7)?</p> TYPO3 Core - Bug #30863: t3lib_pagerendererhttp://forge.typo3.org/issues/30863?journal_id=2556982015-04-13T16:39:39ZRiccardo De Contardierredeco@gmail.com
<ul></ul><p>In TYPO3 CMS 6.2.11 the only occurences of the string "$labelsFromFile[$label]" are in the file</p>
<p>/typo3/sysext/core/Classes/Page/PageRenderer.php, lines 2579 and 2582:</p>
<pre>
foreach ($labels as $label => $value) {
if ($selectionPrefix === '') {
$labelsFromFile[$label] = $value;
} elseif (strpos($label, $selectionPrefix) === 0) {
preg_replace($labelPattern, '', $label);
$labelsFromFile[$label] = $value;
}
}
</pre> TYPO3 Core - Bug #30863: t3lib_pagerendererhttp://forge.typo3.org/issues/30863?journal_id=2650052015-07-08T16:30:53ZRiccardo De Contardierredeco@gmail.com
<ul></ul><p>still present in 7 (latest master), same file, lines 2572 and 2575</p> TYPO3 Core - Bug #30863: t3lib_pagerendererhttp://forge.typo3.org/issues/30863?journal_id=2653352015-07-10T17:14:55ZAlexander Opitzopitz.alexander@googlemail.com
<ul><li><strong>Status</strong> changed from <i>Needs Feedback</i> to <i>New</i></li><li><strong>Target version</strong> set to <i>7.5</i></li></ul> TYPO3 Core - Bug #30863: t3lib_pagerendererhttp://forge.typo3.org/issues/30863?journal_id=2693372015-08-01T11:27:23ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/42201">http://review.typo3.org/42201</a></p> TYPO3 Core - Bug #30863: t3lib_pagerendererhttp://forge.typo3.org/issues/30863?journal_id=2693382015-08-01T11:33:34ZDaniel Goerz
<ul><li><strong>File</strong> <a href="/attachments/29348">inlinelablelfiles_1.0.0_201507312022.zip</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/29348/inlinelablelfiles_1.0.0_201507312022.zip">inlinelablelfiles_1.0.0_201507312022.zip</a> added</li></ul><p>I stumbled over this while updating <a class="external" href="https://forge.typo3.org/issues/57632">https://forge.typo3.org/issues/57632</a>.</p>
<p>You can test this patch with the same example extension I made for the former mentioned. Anyway you have to apply the patch for <a class="external" href="https://forge.typo3.org/issues/57632">https://forge.typo3.org/issues/57632</a> first since the Extension wont work otherwise.</p>
<p>To test ists just the same steps:</p>
<ol>
<li>Install EXT:inlinelablefiles</li>
<li>Create a new PageTree with a new root template record (make sure the page object is configured, Hello World is fine)</li>
<li>Include the static template of EXT:inlinelablefiles</li>
<li>See the output in the frontend (L=1 switches to german labels) in the <head></li>
<li>Play around with the selectionPrefix and stripFromSelectionName options.</li>
</ol> TYPO3 Core - Bug #30863: t3lib_pagerendererhttp://forge.typo3.org/issues/30863?journal_id=2693392015-08-01T11:59:01ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/42201">http://review.typo3.org/42201</a></p> TYPO3 Core - Bug #30863: t3lib_pagerendererhttp://forge.typo3.org/issues/30863?journal_id=2693402015-08-01T12:09:00ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/42201">http://review.typo3.org/42201</a></p> TYPO3 Core - Bug #30863: t3lib_pagerendererhttp://forge.typo3.org/issues/30863?journal_id=2705272015-08-06T13:47:30ZGerrit Code Review
<ul></ul><p>Patch set 4 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/42201">http://review.typo3.org/42201</a></p> TYPO3 Core - Bug #30863: t3lib_pagerendererhttp://forge.typo3.org/issues/30863?journal_id=2705452015-08-06T14:22:27ZDaniel Goerz
<ul><li><strong>Sprint Focus</strong> set to <i>On Location Sprint</i></li></ul> TYPO3 Core - Bug #30863: t3lib_pagerendererhttp://forge.typo3.org/issues/30863?journal_id=2706722015-08-06T20:00:00ZDaniel Goerz
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="[!!!][BUGFIX] Streamline label processing for inline language files Change-Id: If75c125743dfe3e7..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/cf57f0793845fcfeb4edf4fbbe005351b8c7ea25">cf57f0793845fcfeb4edf4fbbe005351b8c7ea25</a>.</p> TYPO3 Core - Bug #30863: t3lib_pagerendererhttp://forge.typo3.org/issues/30863?journal_id=2925302016-01-08T11:18:47ZAnja Leichsenring
<ul><li><strong>Sprint Focus</strong> deleted (<del><i>On Location Sprint</i></del>)</li></ul> TYPO3 Core - Bug #30863: t3lib_pagerendererhttp://forge.typo3.org/issues/30863?journal_id=3456282017-10-19T21:59:20ZRiccardo De Contardierredeco@gmail.com
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>