Bug #32370

Function getObjectByIdentifier of Generic PersistenceManager not complete

Added by Benjamin Heek almost 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Must have
Category:
Persistence
Start date:
2011-12-07
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
No
Complexity:

Description

class: TYPO3\FLOW3\Persistence\Generic\PersistenceManager
method:getObjectByIdentifier
line: 207

code:

$objectData = $this->backend->getObjectDataByIdentifier($identifier);

the method call to `getObjectDataByIdentifier` must also send the $objecttype

$objectData = $this->backend->getObjectDataByIdentifier($identifier,$objectType);

NOTE:
why is the $objectType default set as `NULL` and not just a required argument?

#1

Updated by Karsten Dambekalns almost 10 years ago

  • Category set to Persistence
  • Status changed from New to Accepted
  • Assignee set to Karsten Dambekalns
#2

Updated by Karsten Dambekalns almost 10 years ago

True, it should be passed to the backends, in case it is needed there.

The reason it is optional is that in Generic persistence we did not need it, but we do need it for Doctrine. So we made it optional and check it as needed in the implementation.

#3

Updated by Karsten Dambekalns almost 10 years ago

  • Target version set to 1.1
#4

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7286

#5

Updated by Karsten Dambekalns almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Karsten Dambekalns almost 10 years ago

  • Target version changed from 1.1 to 1.1 beta 1

Also available in: Atom PDF