Task #33097

Usage of preg_match allows side-effects

Added by Adrian Föder almost 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
I18n
Start date:
2012-01-10
Due date:
% Done:

100%

Estimated time:
Sprint:
PHP Version:
Has patch:
Yes
Complexity:
easy

Description

as of http://php.net/function.preg-match the function could also return FALSE if an error occurs (see Return Values and Changelog sections). At some places there is, e.g.,

if (preg_match(self::PATTERN_MATCH_LOCALEIDENTIFIER, $localeIdentifier, $matches) === 0) throw new....

used. This would let a return of FALSE pass by untouched.

#1

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7723

#2

Updated by Karsten Dambekalns almost 10 years ago

  • Target version set to 1.1
#3

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7723

#4

Updated by Adrian Föder over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF