Feature #33494

Verify state and future intentions of a persistence identity VH

Added by Adrian Föder almost 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
ViewHelpers
Start date:
2012-01-27
Due date:
% Done:

100%

Estimated time:
Has patch:
No

Description

Currently, there is an Identity.JsonViewHelper that has two major drawbacks:

  • the Code Example talks about a Persistence.Identity ViewHelper that only outputs raw 97e7e90a-413c-44ef-b2d0-ddfa4387b5ca, for example
  • the actual output of the Identity.JsonViewHelper is json_encode(array('__identity' => $identifier))

additionally, in the Conference package there's a Identity.Uuid that basically also outputs raw 97e7e90a-413c-44ef-b2d0-ddfa4387b5ca.

I do not agree with the following things in the current situation:

  • I think there should be a better name than Persistence.Identity; the "namespace" Persistence doesn't feel good to me. Let's discuss this, maybe you agree.
  • Outputting JSON would not make much sense; at least I'd expect the RAW value put out that could than be edited further (in this case I agree with the code sample's behaviour or the Conference's Identity.Uuid's(same).

Maybe the Format.Json VieHelper I just pushed could be involved, at least as post-processor using ViewHelper chaining or similar.

I really think we should clean up here some things.

--

While writing this, I think at least correcting the Code Example should be duty, and there should be a new flag called e.g. "rawIdentifier" that only returns the plain ID string with no JSON around.

But, well, the VH's name is already JSON, so...
what? :)

Just tell me some guidelines, I will gladly do it.

#1

Updated by Adrian Föder over 9 years ago

  • Tracker changed from Task to Feature
  • Status changed from New to Accepted
#2

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11484

#3

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11484

#4

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11484

#5

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11484

#6

Updated by Gerrit Code Review over 9 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11484

#7

Updated by Gerrit Code Review over 9 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11484

#8

Updated by Karsten Dambekalns over 9 years ago

  • Target version set to 1.1 RC1
#9

Updated by Gerrit Code Review over 9 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11484

#10

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12157

#11

Updated by Adrian Föder over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF