http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692012-02-02T15:57:57ZTYPO3 ForgeTYPO3 Core - Bug #33629: datepicker with datetime field does not set current time as defaulthttp://forge.typo3.org/issues/33629?journal_id=1012752012-02-02T15:57:57ZSimon Schaufelberger
<ul></ul><p>The main source part is in:<br />t3lib/js/extjs/tceforms.js starting from line 63.</p>
<p>i changed to code to this:</p>
<pre>
if (index === 1 && oldValue !== undefined) {
//datetimefield, preserve time information
date.setHours(oldValue.getHours());
date.setMinutes(oldValue.getMinutes());
} else {
oldValue = Date();
date.setHours(oldValue.getHours());
date.setMinutes(oldValue.getMinutes());
}
</pre>
<p>but this does not solve the overwriting of the now current time.</p> TYPO3 Core - Bug #33629: datepicker with datetime field does not set current time as defaulthttp://forge.typo3.org/issues/33629?journal_id=1069812012-03-15T14:16:49ZBenni Mackbenni@typo3.org
<ul><li><strong>File</strong> <a href="/attachments/20338">tceforms_date_datetime_4.5.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20338/tceforms_date_datetime_4.5.patch">tceforms_date_datetime_4.5.patch</a> added</li></ul><p>Attached is a patch that backports all necessary files from 4.6 to 4.5 (the only version where this is happening).</p>
<p>Thanks to punkt.de for fixing this bug!</p> TYPO3 Core - Bug #33629: datepicker with datetime field does not set current time as defaulthttp://forge.typo3.org/issues/33629?journal_id=1076352012-03-19T18:34:26ZSimon Schaufelberger
<ul></ul><p>hi Benny!<br />thank you very much! Can you do me a favor and push this to gerrit please?</p> TYPO3 Core - Bug #33629: datepicker with datetime field does not set current time as defaulthttp://forge.typo3.org/issues/33629?journal_id=1077472012-03-20T11:56:47ZJigal van Hemertjigal.van.hemert@typo3.org
<ul></ul><p>Please ask the RM of 4.5 (Ernesto) if he wants this feature backported. If he agrees the patch can be pushed to the TYPO3_4-5_backports branch.</p> TYPO3 Core - Bug #33629: datepicker with datetime field does not set current time as defaulthttp://forge.typo3.org/issues/33629?journal_id=1077672012-03-20T12:36:05ZSimon Schaufelberger
<ul><li><strong>Assignee</strong> set to <i>Ernesto Baschny</i></li><li><strong>Target version</strong> set to <i>4.5.14</i></li></ul><p>Hi Ernesto,<br />can this BUG be backported to 4.5? This was working well in earlier releases like expected.</p> TYPO3 Core - Bug #33629: datepicker with datetime field does not set current time as defaulthttp://forge.typo3.org/issues/33629?journal_id=1131912012-04-19T17:29:54ZErnesto Baschnyeb@cron.eu
<ul><li><strong>Category</strong> set to <i>Backend User Interface</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Accepted</i></li><li><strong>Target version</strong> changed from <i>4.5.14</i> to <i>4.5.16</i></li></ul><p>@Simon, thanks for bringing that to my attention by mail. I have missed the notification from Forge for this issue.</p>
<p>This seems to be an usability fix and indeed this can and should be solved also on 4.5. The backport from Benni seems to work, and as it clearly fixes the bug it can of course be backported. Remains to be evaluated during the review if there aren't any other side-effects, but since the code works on 4.6 and later, it should be ok.</p>
<p>+1 on backporting</p> TYPO3 Core - Bug #33629: datepicker with datetime field does not set current time as defaulthttp://forge.typo3.org/issues/33629?journal_id=1177842012-05-24T10:53:49ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>Accepted</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>TYPO3_4-5</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/11568">http://review.typo3.org/11568</a></p> TYPO3 Core - Bug #33629: datepicker with datetime field does not set current time as defaulthttp://forge.typo3.org/issues/33629?journal_id=1177872012-05-24T11:06:51ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>TYPO3_4-5</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/11568">http://review.typo3.org/11568</a></p> TYPO3 Core - Bug #33629: datepicker with datetime field does not set current time as defaulthttp://forge.typo3.org/issues/33629?journal_id=1241122012-07-17T10:10:00ZErnesto Baschnyeb@cron.eu
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li><li><strong>Target version</strong> changed from <i>4.5.16</i> to <i>4.5.18</i></li></ul><p>Merged in 4.5. Thanks!</p> TYPO3 Core - Bug #33629: datepicker with datetime field does not set current time as defaulthttp://forge.typo3.org/issues/33629?journal_id=3491562017-10-24T20:20:16ZRiccardo De Contardierredeco@gmail.com
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>