Bug #34050

DatetimeParser code documentation is wrong

Added by Kira Backes over 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Must have
Category:
I18n
Start date:
2012-02-17
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
No
Complexity:

Description

The public methods expect a DateTime object, which they then forward as a string to the internal methods, which then break when using substr on a DateTime object.

#1

Updated by Kira Backes over 9 years ago

This also causes the DateTimeValidator to not work

#2

Updated by Karsten Dambekalns over 9 years ago

  • Category set to I18n
  • Status changed from New to Accepted
  • Assignee set to Karsten Dambekalns
  • Target version set to 1.1
#3

Updated by Bastian Waidelich over 9 years ago

Please check, if https://review.typo3.org/#/c/10070/ already fixes this for you

#4

Updated by Karsten Dambekalns about 9 years ago

  • Target version changed from 1.1 to 1.1 RC1
#5

Updated by Karsten Dambekalns about 9 years ago

  • Subject changed from DatetimeParser does not work to DatetimeParser code documentation is wrong

The code behaves correctly, but the code documentation is wrong - the parser expects strings to parse, in all methods.

#6

Updated by Gerrit Code Review about 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12364

#7

Updated by Gerrit Code Review about 9 years ago

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12373

#8

Updated by Gerrit Code Review about 9 years ago

Patch set 1 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/12374

#9

Updated by Karsten Dambekalns about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF