Feature #34185

SignalSlot Dispatcher should check if Slot method is declared static and act accordingly

Added by Christian Müller over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Could have
Category:
SignalSlot
Target version:
-
Start date:
2012-02-22
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
No
Complexity:

Description

Currently if you connect a $classname + $methodname as slot it will instantiate the class to call $methodname on the instance, even if the method is declared static. I think it wouldn't be a problem to call it static in this case to avoid problems with class instances that shouldn't be there normally.

#1

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Accepted to Under Review
#2

Updated by Karsten Dambekalns over 9 years ago

  • Status changed from Under Review to Accepted
  • Assignee set to Karsten Dambekalns
#3

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9622

#4

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9622

#5

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9622

#6

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9622

#7

Updated by Gerrit Code Review over 9 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9622

#8

Updated by Karsten Dambekalns over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF