Direct Mail

it seems it works well with static recipeints list, but not with "from pages" ones
i'm digging into it

i solved: you have to assign a DB mount to the _cli_scheduler user!

(it is the first time i have to add access permission to this bot :)

note: Daniel wrote about it, in his patch message! how blind we were!!!

I just figured that as well... and wanted to inform you here...
changed the permissions and now it works well...

tricky part was, when i tried it first i manually startet the task in scheduler, so it used my userrights not the _cli_scheduler rights...

thanks to both of you!

Stefano Cecere wrote:

i solved: you have to assign a DB mount to the _cli_scheduler user!

(it is the first time i have to add access permission to this bot :)

hmmm.. this one will break old draft task... user has to be warned to recreate their draft jobs...

Could someone please make a patch for v3.0.3? I've tried adapting it myself, but it didnt work.

Hi couldn't you review this patch?
i'm using it since a lot and it works perfectly..
now i'm updating to 3.1.2 because of the security patch so i checked if you had put this feature in...

Hi,

When I start the task to create a mail from draft manually, works perfect with the patch.
But when these task starts with a server cronjob then create a mail with an empty recipient list.

The supplied patch of course solves the problem. But if you take a look at the methods:

• mod3/class.tx_directmail_recipient_list.php: function cmd_compileMailGroup($group_uid)
• mod2/class.tx_directmail_dmail.php: protected function getSingleMailGroup($group_uid)

you will notice that both are almost identical (duplicate code!). The later one is used from within:

• mod2/class.tx_directmail_dmail.php: protected function cmd_compileMailGroup(array $groups)

I guess instead of making an instance of the SOBE class those methods which are library methods anyways should get moved to somewhere else (tx_directmail_static ?) and used accordingly. Then this new method could get called directly from within the scheduler task to update the recipient list when creating a new sys_dmail record from a draft template.

This would be the cleanest solution. I also opt for NOT putting this methods into tx_directmail_static but rather into a class file on it's own which has to get instanciated. This solves the problem of passing many member variables ($this->perms_clause, $this->userTable, $this->id, $this->fieldList) to every method and additional eliminates the complete duplication of "function update_specialQuery()" !

Markus Knarz wrote:

When I start the task to create a mail from draft manually, works perfect with the patch.
But when these task starts with a server cronjob then create a mail with an empty recipient list.

You have to assign appropriate user rights to the _cli_scheduler user:

• Give correct access rights to the page
• Add a DB mount to the user

I don't know if it is required to assign the _cli_scheduler user to a group having read access to the pages/tt_address table.

Beside from merging the patch to the code the note of Bernhad Kraft should be added to the manual.

The patch works fine for 4.0.0
with a small modification

$SOBE = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance( 'tx_directmail_dmail' );
instead of
$SOBE = t3lib_div::makeInstance( 'tx_directmail_dmail' );

Do we always have to patch future versions of direct mail,
or is it possible to integrate the working patch? ;-)

Patch set 1 for branch master of project TYPO3CMS/Extensions/direct_mail has been pushed to the review server.
It is available at http://review.typo3.org/34490