Bug #34620

Wrong return value for getAccessDecisionVoters()

Added by Bernhard Fischer almost 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Must have
Category:
Security
Start date:
2012-03-06
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
No
Complexity:
no-brainer

Description

The return value of the function getAccessDecisionVoters() in the AccessDecisionVoterManager should return a array. It doesn't really matter because this function is never referenced.
Type hinting for $securityContext is missing the leading \ and hinting for $authenticationManager in the PolicyEnforcement is also wrong.

#1

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9430

#2

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9430

#3

Updated by Karsten Dambekalns almost 9 years ago

  • Assignee set to Bernhard Fischer
  • Target version set to 1.0.4
#4

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9430

#5

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch FLOW3-1.0 has been pushed to the review server.
It is available at http://review.typo3.org/9589

#6

Updated by Bernhard Fischer almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF