http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692012-03-11T22:02:02ZTYPO3 ForgeTYPO3 Core - Bug #34695: missing parameter for implode in showpic.phphttp://forge.typo3.org/issues/34695?journal_id=1063412012-03-11T22:02:02ZJigal van Hemertjigal.van.hemert@typo3.org
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Needs Feedback</i></li><li><strong>Assignee</strong> set to <i>Jigal van Hemert</i></li></ul><p>According to PHP documentation [1] the 'glue' parameter became optional in 4.3.0; it's not needed if it's empty.</p>
<p>Have you encountered errors or other problems?</p>
<p>[1] <a class="external" href="http://www.php.net/implode">http://www.php.net/implode</a></p> TYPO3 Core - Bug #34695: missing parameter for implode in showpic.phphttp://forge.typo3.org/issues/34695?journal_id=1063452012-03-11T22:39:00ZSimon Schaufelberger
<ul></ul><p>phpstorm does not like it and:</p>
<blockquote>
<p>This is <strong>not the preferred usage</strong> of implode() as glue would be the second parameter and thus, <strong>the bad prototype would be used</strong>.</p>
</blockquote>
<p>but there were no errors so far.</p> TYPO3 Core - Bug #34695: missing parameter for implode in showpic.phphttp://forge.typo3.org/issues/34695?journal_id=1067452012-03-14T10:12:57ZOliver Haderoliver.hader@typo3.org
<ul><li><strong>Status</strong> changed from <i>Needs Feedback</i> to <i>Accepted</i></li><li><strong>Priority</strong> changed from <i>Must have</i> to <i>Should have</i></li><li><strong>Target version</strong> set to <i>4.5.14</i></li></ul> TYPO3 Core - Bug #34695: missing parameter for implode in showpic.phphttp://forge.typo3.org/issues/34695?journal_id=1111192012-04-08T08:27:54ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>Accepted</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/10192">http://review.typo3.org/10192</a></p> TYPO3 Core - Bug #34695: missing parameter for implode in showpic.phphttp://forge.typo3.org/issues/34695?journal_id=1111202012-04-08T08:33:06ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>TYPO3_4-7</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/10193">http://review.typo3.org/10193</a></p> TYPO3 Core - Bug #34695: missing parameter for implode in showpic.phphttp://forge.typo3.org/issues/34695?journal_id=1111212012-04-08T08:36:34ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>TYPO3_4-6</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/10194">http://review.typo3.org/10194</a></p> TYPO3 Core - Bug #34695: missing parameter for implode in showpic.phphttp://forge.typo3.org/issues/34695?journal_id=1111222012-04-08T08:41:04ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>TYPO3_4-5</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/10195">http://review.typo3.org/10195</a></p> TYPO3 Core - Bug #34695: missing parameter for implode in showpic.phphttp://forge.typo3.org/issues/34695?journal_id=1111722012-04-08T14:30:38ZJigal van Hemertjigal.van.hemert@typo3.org
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="[BUGFIX] missing parameter for implode Use the preferred syntax for implode() Change-Id: I0103b..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/f9fe38ee604e9985b898ef590e9acd966d1dc92a">f9fe38ee604e9985b898ef590e9acd966d1dc92a</a>.</p> TYPO3 Core - Bug #34695: missing parameter for implode in showpic.phphttp://forge.typo3.org/issues/34695?journal_id=3491642017-10-24T20:20:18ZRiccardo De Contardierredeco@gmail.com
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>