Using Locale parser in Float TypeConverter
since the Validator has it, it would be nice and useful to let the Property Mapper use the Locale parser to differentiate between various given decimal and thousands separators
Updated by Alexander Berl almost 9 years ago
I'd suggest using $this->localizationService->getConfiguration()->getCurrentLocale() instead of $this->localizationService->getConfiguration()->getDefaultLocale(), because it falls back to default locale but allows for overriding the locale via code (for example by parsing Accept-Language headers, or from session).
Other than that +1
Updated by Alexander Berl over 8 years ago
- File 0001-FEATURE-FloatConverter-uses-Locale-parser.patch 0001-FEATURE-FloatConverter-uses-Locale-parser.patch added
I'm not sure how to push a change to this changeset and found no one on the IRC channel to give me some hints, so I'm just adding a patch diff.
This fixes the failing test when no configuration is given with the convertFrom call, adds conversion from float => float which resolves #35173 and adds some more unit tests for the new functionality.