Task #37608

Functional routing tests

Added by Bastian Waidelich over 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Should have
Category:
MVC - Routing
Start date:
2012-05-30
Due date:
% Done:

100%

Estimated time:
Sprint:
PHP Version:
Has patch:
No
Complexity:

Description

Some important routing features urgently need functional tests

#1

Updated by Bastian Waidelich over 9 years ago

  • Target version changed from 1.1 RC1 to 1.1

Almost ready, but not completely.. ;)

#2

Updated by Karsten Dambekalns over 9 years ago

Any news on this one?

#3

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12379

#4

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12380

#5

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12379

#6

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12379

#7

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12380

#8

Updated by Bastian Waidelich about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Christopher Hlubek about 9 years ago

I get errors in an HTTP functional test for FLOW3 1.1 after this change. I know this worked last week in a demo application:

Uncaught Exception in FLOW3 #1301650951: No controller object was found for package "myvendor.mypackage", subpackage "Tests\Functional\Mvc\Fixtures", controller "login" in route "FLOW3 :: Functional Test: controller route parts are case insensitive".
thrown in file .../Data/Temporary/Testing/Cache/Code/FLOW3_Object_Classes/TYPO3_Fluid_ViewHelpers_Link_ActionViewHelper_Original.php
in line 90

I'm just generating a link inside a Fluid template (<f:link.action action="index" controller="Login">Login</f:link.action>) of a Standard controller in an indexAction.

The problem seems to be the route "FLOW3 :: Functional Test: controller route parts are case insensitive" which throws an exception after merging the given route values (which do not contain a subpackage) on the defaults (which define a subpackage Tests\Functional\...) because a controller with that name could not be found (which is correct, since the LoginController does not exist for subpackage Test\Functional\Mvc\Fixtures).

So either we have to fix the subpackage override (no or NULL subpackage overrides a given subpackage) or disable the exception and just return FALSE in resolves(...) if the controller object is not found.

Also available in: Atom PDF