Bug #38435

Reset the router for each functional test

Added by Bastian Waidelich almost 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Must have
Assignee:
Bastian Waidelich
Category:
- Testing -
Target version:
TYPO3 Flow Base Distribution - 1.1
Start date:
2012-06-27
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
No
Complexity:
no-brainer

Description

Currently all functional tests share the same instance of \TYPO3\FLOW3\Mvc\Routing\Router because the InternalRequestEngine is of scope singleton.
This leads to unexpected results and failing tests if tests add custom routes.

The router instance should be reset for each test case.

#1

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12402

#2

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12402

#3

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12402

#4

Updated by Gerrit Code Review almost 10 years ago

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12405

#5

Updated by Gerrit Code Review almost 10 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12402

#6

Updated by Karsten Dambekalns almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Bastian Waidelich almost 10 years ago

  • Status changed from Resolved to Accepted
  • % Done changed from 100 to 0

The solution provided with http://review.typo3.org/12402 did not solve the issue. We need to reset the InternalRequestEngine as the router can't be reset for some reason.

#8

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12661

#9

Updated by Gerrit Code Review almost 10 years ago

Patch set 1 for branch FLOW3-1.1 has been pushed to the review server.
It is available at http://review.typo3.org/12662

#10

Updated by Bastian Waidelich almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF