Task #38986

Task #38984: Code Review

TYPO3 Extension Review

Added by Tizian Schmidlin over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Must have
Category:
TYPO3 4.x
Start date:
2012-07-16
Due date:
% Done:

100%

Estimated time:
5.00 h
Spent time:

Description

TYPO3 Extension review:
- class.tx_phoenixlogin_call.php

Bemerkungen im code und hier vermeken.

#1

Updated by Tizian Schmidlin over 9 years ago

  • Category set to TYPO3 4.x
  • Assignee set to Ivan no-lastname-given
#2

Updated by Ivan no-lastname-given over 9 years ago

Bemerkungen sind ebenfalls im Code vorhanden. Bitte entfernen, wenn behoben:
- I'm not an expert on cryptography, but since you're using a deterministic pseudorandom number generator the password may be predictable. But for our purposes this should not be a problem.
- It would be more readable if you would call userExists above the if statement, and check with the === operator if the method has returned false. Or use brackets like this - > !($this->user = $this->userExists())
- Why are the methods userExists() and generateRandomPassword() public? If they're not needed outside this class, make them private
- Remove all comments that are not needed like the one below
//print_r(base64_decode($_GET['encrypted']));die();

#3

Updated by Ivan no-lastname-given over 9 years ago

  • Status changed from New to Closed
#4

Updated by Tizian Schmidlin over 9 years ago

  • % Done changed from 0 to 100

Also available in: Atom PDF