Task #38984: Code Review
TYPO3 Extension Review
TYPO3 Extension review:
Bemerkungen im code und hier vermeken.
Updated by Ivan no-lastname-given over 9 years ago
Bemerkungen sind ebenfalls im Code vorhanden. Bitte entfernen, wenn behoben:
- I'm not an expert on cryptography, but since you're using a deterministic pseudorandom number generator the password may be predictable. But for our purposes this should not be a problem.
- It would be more readable if you would call userExists above the if statement, and check with the === operator if the method has returned false. Or use brackets like this - > !($this->user = $this->userExists())
- Why are the methods userExists() and generateRandomPassword() public? If they're not needed outside this class, make them private
- Remove all comments that are not needed like the one below