Task #3987

Inconsistent attribute naming in Form view helper

Added by Robert Lemke about 10 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Must have
Category:
ViewHelpers
Target version:
Start date:
2009-09-05
Due date:
2009-09-05
% Done:

100%

Has patch:

Description

The action link view helper uses the following attributes for specifying the action:

   <f:link.action action="show" controller="Post" package="Blog" ...

The form view helper, however, uses other attribute names:
   <f:form action="create" controllerName="Comment" packageName="Blog" subpackageName="Foo">

That is not only incosistent with the link view helper but also in general (we never use "packageName" but only "packageKey").

Please rename the attributes as follows:

controllerName -> controller
packageName -> package
subpackageName -> subpackage

Note that names like "controller", "package" etc. should only be used for attributes in Fluid templates. We make the exception there to provide shorter names for the users. Generally in PHP code we'd rather use "controllerName", "packageKey" etc.


Related issues

Follows TYPO3.Flow - Feature #4457: Improve UriBuilder Resolved 2009-09-04

History

#1 Updated by Robert Lemke about 10 years ago

  • Target version changed from 1.0.0 alpha 3 to 1.0

#2 Updated by Bastian Waidelich about 10 years ago

  • Assignee set to Bastian Waidelich

I'll take care of that during the UriBuilder rewrite (90% finished)

#3 Updated by Bastian Waidelich about 10 years ago

  • % Done changed from 0 to 100

Pending in #4457

#4 Updated by Bastian Waidelich about 10 years ago

Applied in changeset r3131.

#5 Updated by Bastian Waidelich about 10 years ago

  • Status changed from New to Resolved

Also available in: Atom PDF