http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692012-10-10T17:48:40ZTYPO3 ForgeTYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1359402012-10-10T17:48:40ZSteffen Gebertsteffen.gebert@typo3.org
<ul></ul><p>Sounds reasonable, Till.</p>
<p>We have a function <code>t3lib_div::flushOutputBuffers()</code> (in 4.x) / <code>TYPO3\CMS\Core\Utility\GeneralUtility</code> in (6.0) to flush output buffers.</p>
<p>It would be great, if you could push your patch with that correction into the review workflow. See <a class="external" href="http://wiki.typo3.org/Contribution_Walkthrough_Tutorials">http://wiki.typo3.org/Contribution_Walkthrough_Tutorials</a> and ask here in the mailing lists, if you have any questions!</p>
<p>Yours<br />Steffen</p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1360212012-10-11T11:21:29ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>TYPO3_4-7</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15507">http://review.typo3.org/15507</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1360222012-10-11T11:23:02ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15508">http://review.typo3.org/15508</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1360482012-10-11T12:39:23ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>TYPO3_4-6</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15509">http://review.typo3.org/15509</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1360532012-10-11T12:48:09ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>TYPO3_4-5</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15510">http://review.typo3.org/15510</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1360542012-10-11T12:52:35ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>TYPO3_4-4</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15511">http://review.typo3.org/15511</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1360552012-10-11T12:59:41Ztill buschbuti@bux.at
<ul></ul>i have tried to add the changes to gerrit. i'm not quite sure if what i did is good/conforms to standars:
<ul>
<li>one commit for each version i want to change</li>
<li>commits for 4.x series have the same Change-Id</li>
<li>i have not tested if jumpurl works with typo3 6.x after the change</li>
</ul>
<p>also i'm not sure if stat() should be @stat()</p>
<p>Steffen Gebert wrote:</p>
<blockquote>
<p>...<br />It would be great, if you could push your patch with that correction into the review workflow. See <a class="external" href="http://wiki.typo3.org/Contribution_Walkthrough_Tutorials">http://wiki.typo3.org/Contribution_Walkthrough_Tutorials</a> and ask here in the mailing lists, if you have any questions!<br />...</p>
</blockquote> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1360692012-10-11T15:09:00ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>TYPO3_4-4</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15511">http://review.typo3.org/15511</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1360702012-10-11T15:11:56ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>TYPO3_4-7</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15507">http://review.typo3.org/15507</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1360712012-10-11T15:13:59ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>TYPO3_4-6</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15509">http://review.typo3.org/15509</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1360722012-10-11T15:14:20ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>TYPO3_4-5</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15510">http://review.typo3.org/15510</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1360732012-10-11T15:18:32ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15508">http://review.typo3.org/15508</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1360742012-10-11T15:23:12ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15508">http://review.typo3.org/15508</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1360772012-10-11T15:31:30ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>TYPO3_4-6</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15509">http://review.typo3.org/15509</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1360782012-10-11T15:33:58ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>TYPO3_4-5</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15510">http://review.typo3.org/15510</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1360792012-10-11T15:35:21ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>TYPO3_4-4</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15511">http://review.typo3.org/15511</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1360812012-10-11T15:48:53ZGerrit Code Review
<ul></ul><p>Patch set 4 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15508">http://review.typo3.org/15508</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1361192012-10-12T00:37:35ZSteffen Gebertsteffen.gebert@typo3.org
<ul></ul><p>Thanks for pushing, Till!</p>
<p>Let's review it for master first and then we will take care of the other branches!</p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1361202012-10-12T00:40:34ZGerrit Code Review
<ul></ul><p>Patch set 5 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15508">http://review.typo3.org/15508</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1361522012-10-12T13:47:28ZGerrit Code Review
<ul></ul><p>Patch set 6 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15508">http://review.typo3.org/15508</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1362062012-10-12T21:16:44ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>TYPO3_4-7</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15507">http://review.typo3.org/15507</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1362072012-10-12T21:24:29ZGerrit Code Review
<ul></ul><p>Patch set 4 for branch <strong>TYPO3_4-6</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15509">http://review.typo3.org/15509</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1362092012-10-12T21:34:13ZGerrit Code Review
<ul></ul><p>Patch set 4 for branch <strong>TYPO3_4-5</strong> has been pushed to the review server.<br />It is available at <a class="external" href="http://review.typo3.org/15510">http://review.typo3.org/15510</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1716872013-07-03T17:01:23ZAlexander Opitzopitz.alexander@googlemail.com
<ul></ul><p>Hi Till,</p>
<p>can you please rebase your patch to latest master?</p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1719432013-07-05T12:01:17ZGerrit Code Review
<ul></ul><p>Patch set 4 for branch <strong>TYPO3_4-7</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/15507">https://review.typo3.org/15507</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1719442013-07-05T12:04:15ZGerrit Code Review
<ul></ul><p>Patch set 7 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/15508">https://review.typo3.org/15508</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1719482013-07-05T12:07:42ZGerrit Code Review
<ul></ul><p>Patch set 8 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/15508">https://review.typo3.org/15508</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1719492013-07-05T12:10:35ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>TYPO3_6-1</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/21917">https://review.typo3.org/21917</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1719512013-07-05T12:11:03ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>TYPO3_6-0</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/21918">https://review.typo3.org/21918</a></p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1719592013-07-05T12:30:29Ztill buschbuti@bux.at
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="[BUGFIX] Improve jumpUrl download of large files * Prevent output-buffering * Add Content-Length..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/09c934e2e6892af3f341df9a22dff93d7b3e4395">09c934e2e6892af3f341df9a22dff93d7b3e4395</a>.</p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1822622013-09-10T18:10:37ZNils Böcherinfo@nbpromedia.com
<ul></ul><p>Gerrit Code Review wrote:</p>
<blockquote>
<p>Patch set 1 for branch <strong>TYPO3_6-1</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/21917">https://review.typo3.org/21917</a></p>
</blockquote>
<p>After this update (TYPO3 6.1.4) the header "Content-Length" for every download file showed a size of 26 bytes, no matter how big the file was.<br />The calculation of the filesize seems to be not working correctly.</p>
<p>I deleted line 2854 in TypoScriptFrontendController.php (header('Content-Length: ' . filesize($absoluteFileName));) as quick workaround.</p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=1822632013-09-10T18:18:04ZAlexander Opitzopitz.alexander@googlemail.com
<ul><li><strong>Is Regression</strong> set to <i>No</i></li></ul><p>@Nils Böcher</p>
<p>Please open a new issue for this. From reading the source it should work. Please write in this issue your PHP version which you use. And the complete response header to get this analyzed.</p>
<p>Thanks.</p> TYPO3 Core - Bug #41718: improve (jumpurl) download of large fileshttp://forge.typo3.org/issues/41718?journal_id=3845882018-10-02T12:16:41ZBenni Mackbenni@typo3.org
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>