Bug #41848

TYPO3 Flow Base Distribution - Bug #41843: Composer and rename issues (umbrella issue)

Core migration tool applies migrations twice

Added by Adrian Föder over 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Must have
Category:
Core
Start date:
2012-10-10
Due date:
% Done:

100%

Estimated time:
PHP Version:
Has patch:
No
Complexity:

Description

With for example my MooTools.Packager repository located here: http://git.typo3.org/FLOW3/Packages/MooTools.Packager.git I get the following situation when running core:migrate then:

Applying TYPO3.FLOW3-201209201112
  Migrating MooTools.Packager
fatal: Could not switch to 'C:/Users/afoeder/PhpstormProjects/acme/Distribution/Packages/Application/MooTools.Packager/Meta': No such file or directory
    [master c322f04] [TASK] Apply migration TYPO3.FLOW3-201209201112
     4 files changed, 2 insertions(+), 2 deletions(-)
     rename Classes/MooTools/Packager/{ => }/MooTools/Packager/Service/PackageBuildConfiguration.php (100%)
     rename Classes/MooTools/Packager/{ => }/MooTools/Packager/Service/PackageBuildService.php (100%)
     rename Classes/MooTools/Packager/{ => }/MooTools/Packager/ViewHelpers/JavaScriptFileViewHelper.php (100%)
  Skipping Twitter.Bootstrap, the migration is already applied.
  Skipping TYPO3.Aloha, the migration is already applied.
  Skipping TYPO3.Comments, the migration is already applied.
  Skipping TYPO3.Eel, the migration is already applied.
  Skipping TYPO3.ElasticSearch, the migration is already applied.
  Skipping TYPO3.ExtJS, the migration is already applied.
  Skipping TYPO3.Form, the migration is already applied.
  Skipping TYPO3.Imagine, the migration is already applied.
  Skipping TYPO3.Media, the migration is already applied.
  Skipping TYPO3.Phoenix.ContentTypes, the migration is already applied.
  Skipping TYPO3.Setup, the migration is already applied.
  Skipping TYPO3.SiteKickstarter, the migration is already applied.
  Skipping TYPO3.TYPO3, the migration is already applied.
  Skipping TYPO3.TYPO3CR, the migration is already applied.
  Skipping TYPO3.TypoScript, the migration is already applied.

The git log afterwards then says

commit c322f040a516bcb2ac105e829d25d91cafeb251c
Author: Adrian Föder <adrian@foeder.de>
Date:   Wed Oct 10 15:38:10 2012 +0200

    [TASK] Apply migration TYPO3.FLOW3-201209201112

    Change-Id: Ife57be5c01835f7bd97c7664cc55d3c55c7e8fa9

commit 857067ec5487b788bf9b86728952e20fb7d1093f
Author: Adrian Föder <adrian@foeder.de>
Date:   Wed Oct 10 13:45:30 2012 +0200

    [TASK] Last trivial FLOW3 to Flow renamings

    Change-Id: Ib5d96ca495c3c1bb39081a6098a394a3bf892e54

commit 01fc419cc1325ec951f4b74e49afbf64ee426188
Author: Adrian Föder <adrian@foeder.de>
Date:   Tue Oct 9 16:41:15 2012 +0200

    Deleted package.php file

    Change-Id: Iedc30438328f2f2f5d1b295ee2c3f64d3be1cc77

commit ec2705c3639820465331607c8fe47aaf29e1c734
Author: Adrian Föder <adrian@foeder.de>
Date:   Tue Oct 9 16:39:18 2012 +0200

    [TASK] Apply migration TYPO3.Flow-201209251426

    Change-Id: I31c8d8915d66507c8b8784d9292cf2c626816d17

commit 6dfad6702899c6f934558607ab50dce64dcde204
Author: Adrian Föder <adrian@foeder.de>
Date:   Tue Oct 9 16:39:18 2012 +0200

    [TASK] Apply migration TYPO3.FLOW3-201209201112

    Change-Id: Ie673fa7944b0d85916ece96c75ba4e3f7f14fe95
:

it can clearly be seen that the -1112 migration is applied twice.
Afterwards, the actual class files lay here:

`Classes/MooTools/Packager/MooTools/Packager/[heretheyare]`.

#1

Updated by Robert Lemke over 8 years ago

  • Priority changed from Should have to Must have
  • Target version set to 2.0 beta 1
#2

Updated by Robert Lemke over 8 years ago

  • Project changed from TYPO3 Flow Base Distribution to TYPO3.Flow
#3

Updated by Robert Lemke over 8 years ago

  • Category set to Core
  • Has patch set to No
#4

Updated by Christopher Hlubek over 8 years ago

  • Status changed from New to Accepted
  • Assignee set to Christopher Hlubek

I also ran into that an hour ago, so I'll supply a fix for that.

#5

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15531

#6

Updated by Karsten Dambekalns over 8 years ago

Well, the interesting part: why are there no Migration: 2012... footers in the commit messages? If they are indeed lacking, this fixes a symptom of something else. Although the check in the suggested change makes sense - it will skip packages that were coded with PSR-0 from the start.

#7

Updated by Karsten Dambekalns about 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF