http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692012-10-26T15:37:37ZTYPO3 ForgeTYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1380352012-10-26T15:37:37ZOliver Haderoliver.hader@typo3.org
<ul><li><strong>Priority</strong> changed from <i>Should have</i> to <i>Must have</i></li></ul> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1384242012-10-30T11:22:08ZBenni Mackbenni@typo3.org
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Accepted</i></li><li><strong>Target version</strong> set to <i>4.7.6</i></li><li><strong>Complexity</strong> set to <i>easy</i></li></ul> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1432402012-12-02T16:28:02ZSebastian Schmalsebastian.schmal@gmx.de
<ul></ul><p>the same problem in 4.6.15 :(<br />plz bugfix!</p> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1432432012-12-02T16:30:33ZSebastian Schmalsebastian.schmal@gmx.de
<ul></ul><pre>
plugin.tx_indexedsearch._LOCAL_LANG.de {
pi_list_browseresults_page =
pi_list_browseresults_next = nächste
pi_list_browseresults_prev = vorherige
word_page =
word_pages =
}
</pre>
<p>Output:<br /><pre>
<< < Page 1 Page 2 Page 3 Page 4 Page 5 > >>
</pre></p> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1457652012-12-19T13:26:50ZElmar Athmerathmer@leonex.de
<ul></ul><p>Same in TYPO3 6.0.</p> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1478422013-01-15T17:40:33ZJens Hoppej.hoppe@minuskel.de
<ul></ul><p>Same problem in TYPO3 4.7.7 with tt_news 3.2.1</p> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1490672013-01-29T12:00:26ZAndreas Becker
<ul></ul><p>Also in TYPO3 4.7.7 with tt_news 3.4.0.</p>
<p>Are there any workarounds?</p>
<p>Btw... Target version should be updated.</p> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1490742013-01-29T12:40:29ZJens Pauljpaul@tiff.any.de
<ul></ul><p>I have a ugly workaround :(</p>
<p>- make a copy from tt_news_userPageBrowserFunc.php<br />- in your TS:<br />includeLibs.userPageBrowserFunc = fileadmin/templates/main/tt_news_userPageBrowserFunc.php</p>
<p>and<br />plugin.tt_news.userPageBrowserFunc = user_substPageBrowser2</p>
<p>- edit in tt_news_userPageBrowserFunc.php<br />below: function user_substPageBrowser2 ($markerArray, $conf) { ...<br />the Marker ###BROWSE_LINKS### around line 233</p>
<p><strong>original:</strong><br />for ($i = $firstPage ; $i < $lastPage; $i++) {<br /> if (($begin_at >= $i * $pObj->config['limit']) && ($begin_at < $i * $pObj->config['limit'] + $pObj->config['limit'])) {<br /> $item = ($pObj->conf['pageBrowser.']['showPBrowserText']?$pObj->pi_getLL('pi_list_browseresults_page', 'Page'):'') . (string)($i + 1);<br /> $markerArray['###BROWSE_LINKS###'] .= ' ' . $pObj->local_cObj->stdWrap($item, $pObj->conf['pageBrowser.']['actPage_stdWrap.']) . ' ';<br /> } else {<br /> $item = ($pObj->conf['pageBrowser.']['showPBrowserText']?$pObj->pi_getLL('pi_list_browseresults_page', 'Page'):'') . (string)($i + 1);
<p>$markerArray['###BROWSE_LINKS###'] .= $pObj->pi_linkTP_keepPIvars($pObj->local_cObj->stdWrap($item, $pObj->conf['pageBrowser.']['page_stdWrap.']) . ' ', array('pointer' => $i), $pObj->allowCaching) . ' ';<br /> } <br />}</p>
</p>
<p><strong>new:</strong><br />for ($i = $firstPage ; $i < $lastPage; $i++) {<br /> if (($begin_at >= $i * $pObj->config['limit']) && ($begin_at < $i * $pObj->config['limit'] + $pObj->config['limit'])) {<br /> $item = ($i + 1);<br /> $markerArray['###BROWSE_LINKS###'] .= '<span class="activeLinkWrap">' . $pObj->local_cObj->stdWrap($item, $pObj->conf['pageBrowser.']['actPage_stdWrap.']) . '</span>';<br /> } else {<br /> $item = ($i + 1);
<p>$markerArray['###BROWSE_LINKS###'] .= $pObj->pi_linkTP_keepPIvars($pObj->local_cObj->stdWrap($item, $pObj->conf['pageBrowser.']['page_stdWrap.']) . '', array('pointer' => $i), $pObj->allowCaching) . '';<br /> }<br />}</p>
</p>
<p>This is my workaround currently<br />Result ony numbers</p> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1526662013-02-27T01:12:36Zamus amus@musall.net
<ul></ul><p>A simple workaround:</p>
<pre>
plugin.tx_indexedsearch {
_LOCAL_LANG.de.pi_list_browseresults_page = ###
_LOCAL_LANG.default.pi_list_browseresults_page = ###
stdWrap.replacement {
10 {
search = ###
replace =
}
}
}
</pre> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1534672013-03-05T11:06:26ZMatthias Oberritter
<ul></ul><p>Sorry, "simple Workaround" won't work for Typo3 4.7.8, Indexed Search 4.7.7. Any other suggestions?</p> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1534682013-03-05T11:32:48ZDaniel d.renkel@gmx.de
<ul></ul><p>Matthias wrote:</p>
<blockquote>
<p>Sorry, "simple Workaround" won't work for Typo3 4.7.8, Indexed Search 4.7.7. Any other suggestions?</p>
</blockquote>
<p>You must use <strong>tt_news</strong> instead of <strong>tx_indexedsearch</strong></p>
<pre>
plugin.tt_news {
_LOCAL_LANG.de.pi_list_browseresults_page = ###
_LOCAL_LANG.default.pi_list_browseresults_page = ###
stdWrap.replacement {
10 {
search = ###
replace =
}
}
}
</pre> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1550472013-03-18T18:18:05Zsushie.net
<ul></ul><p>Same Issue in Typo3 4.7.10 / Indexed Search 4.7.7</p>
<p>both "simple Workaround" wont work for me (dont have tt_news installed anyway)... any other suggestions except patching php ?</p>
<p>*cheers</p> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1550482013-03-18T18:31:00Zsushie.net
<ul></ul><p>quick workaround with jquery</p>
<pre>
$(document).ready(function(){
$('ul.browsebox li a').each(function(){
$(this).html($(this).html().replace('Page ', ''));
});
});
</pre>
<p>*s</p> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1700252013-06-20T09:37:48ZKim Christiansenchristiansen@new-communication.de
<ul></ul><p>Try this:</p>
<p>_LOCAL_LANG.default.pi_list_browseresults_page (</p>
<p>)</p>
<p>The empty line must be kept!</p> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1728842013-07-11T12:23:48ZSven Burkertbedienung@sbtheke.de
<ul></ul><p>Is this now fixed? I had this problem, too, but now it is gone (TYPO3 4.7.12, tt_news 3.4.0).</p> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1798862013-08-30T11:20:12ZDimitri Lavrenükdimi@gumka.de
<ul></ul><p>Here is a fix for Typo3 6.x</p>
<p>/typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php</p>
<p>Line 532<br />change <br /> $pageText = trim($this->pi_getLL('pi_list_browseresults_page', 'Page', $hscText) . ' ' . ($a + 1));</p>
<p>to</p>
<pre><code>$pageText = trim($this->pi_getLL('pi_list_browseresults_page', '', $hscText) . ' ' . ($a + 1));</code></pre>
<p>As you can see, the 'Page' is hardcoded in the core as an alternative label</p> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=1799162013-08-30T13:13:28ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>Accepted</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/23486">https://review.typo3.org/23486</a></p> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=2420082014-12-22T16:30:27ZRyan Klarhöltermail@ryanklarhoelter.name
<ul></ul><p>This is not a core bug and the fix shouldn't be implemented, it's a tt_news bug. It has to do with changes made in the TYPO3 method pi_getLL introduced by commit aef055c88c5954444bbc9f226b33ecc04532a748 (<a class="external" href="https://review.typo3.org/#/c/14237/">https://review.typo3.org/#/c/14237/</a>) and later extended/fixed by 97a6a1bcd74817d7ae764d7e76fc37a222b4ef71 (<a class="external" href="https://review.typo3.org/#/c/17151/">https://review.typo3.org/#/c/17151/</a>). The underlying problem is not that the string "Page" is hard coded (I think this has a useful reason). Nevertheless it wouldn't fix the problem because tt_news is calling the pi_getLL method by it's own (with "Page" as alternative label too). So fixing it in the core hasn't any effect. I have suggested a solution in <a class="external" href="https://forge.typo3.org/issues/43804#note-3">https://forge.typo3.org/issues/43804#note-3</a>.</p> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=2473972015-01-29T20:47:32ZBenni Mackbenni@typo3.org
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Rejected</i></li><li><strong>Is Regression</strong> set to <i>No</i></li></ul><p>this issue is not related to the core but expected behaviour.</p> TYPO3 Core - Bug #42299: Since 4.7.5 _LOCAL_LANG pi_list_browseresults_page can´t be emptyhttp://forge.typo3.org/issues/42299?journal_id=3004642016-03-29T11:26:36ZMichael Stuckimichael.stucki@typo3.org
<ul></ul><p>To deal with this, you need to set the following in your plugin:</p>
<pre>
$this->LOCAL_LANG_UNSET[$this->LLkey][$key] = '';
</pre>
<p>See #43804 / <a class="external" href="https://review.typo3.org/#/c/39706/">https://review.typo3.org/#/c/39706/</a></p>