Bug #43621

Composer installer overwrites Settings.yaml.example

Added by Christopher Hlubek almost 8 years ago. Updated about 7 years ago.

Status:
Under Review
Priority:
Must have
Category:
-
Target version:
-
Start date:
2012-12-05
Due date:
% Done:

0%

Estimated time:
PHP Version:
Has patch:
No
Complexity:

Description

The Flow composer installer seems to overwrite an existing file in Configuration/Settings.yaml.example which should not happen for custom distributions.

#1

Updated by Karsten Dambekalns almost 8 years ago

  • Status changed from New to Needs Feedback
  • Assignee set to Karsten Dambekalns

Well, when I added those files, I figured the example file should be updated with Flow - otherwise one would easily be trapped with an outdated example file. We could move it to be a "default" instead of "essential", then it would not be overwritten. But also not be overwritten in case you would want it to be overwritten because it is not part of a custom distribution…

#2

Updated by Christopher Hlubek almost 8 years ago

I would be in favor of using the "default" approach which sounds reasonable for me. As a user I would not expect the example file to be updated on subsequent calls to "composer update".

#4

Updated by Gerrit Code Review about 7 years ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/25686

#5

Updated by Gerrit Code Review about 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.Flow has been pushed to the review server.
It is available at https://review.typo3.org/25686

Also available in: Atom PDF