Bug #43817

patches/reviews are not attached to forge-issue

Added by Peter Niederlag about 9 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Must have
Category:
-
Target version:
-
Start date:
2012-12-10
Due date:
% Done:

0%

Estimated time:

#1

Updated by Tomita Militaru about 9 years ago

I can confirm the problem.

#2

Updated by Karsten Dambekalns about 9 years ago

Classic error that could be the reason: the empty line before the Change-Id line.

This breaks the "footer" in two blocks, at least Gerrit will only consider the Change-Id part of the footer now. Result: Issue id search won't pick up this change (see https://review.typo3.org/#/q/tr:43426,n,z).

Maybe redmine works similar?

#3

Updated by Tomita Militaru about 9 years ago

I've just amended the last commit of one of my change requests and removed the empty line. Unfortunately, that didn't work either.
See sample: https://review.typo3.org/#/c/17049/

#4

Updated by Steffen Gebert about 9 years ago

[2012-12-11 16:25:06,549] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output: Executing hook patchset-created file /var/gerrit/review/hooks/patchset-created.d/update-forge-issue.php
[2012-12-11 16:25:06,560] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output: Format mismatch. Expected $argv to have have length 17. Got (length: 19):
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output: Array
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output: (
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [0] => /var/gerrit/review/hooks/patchset-created.d/update-forge-issue.php
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [1] => --change
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [2] => I5e6ba540d7d828bd24417356b887182966fb581c
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [3] => --is-draft
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [4] => false
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [5] => --change-url
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [6] => https://review.typo3.org/17102
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [7] => --project
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [8] => TYPO3v4/CoreProjects/MVC/extbase
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [9] => --branch
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [10] => master
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [11] => --topic
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [12] => 43887
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [13] => --uploader
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [14] => Alexander Schnitzler (typo3@alexanderschnitzler.de)
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [15] => --commit
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [16] => 840e875318e0a35e3f81d8bf3477cf94e730524e
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [17] => --patchset
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output:     [18] => 2
[2012-12-11 16:25:06,561] INFO  com.google.gerrit.common.ChangeHookRunner : hook[patchset-created] output: )

Have no time today, but the order / number of parameters has changed (IIRC the draft is new). Peter, if you want to take over it's in site-cookbooks/templates/default/host-srv.../hooks/ (and the log is from gerrit's error_log).

#5

Updated by Steffen Gebert about 9 years ago

  • Status changed from Accepted to Resolved
  • Assignee set to Steffen Gebert

Resolved in the meantime.

#6

Updated by Steffen Gebert over 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF