TYPO3 Core

This bug is still present in TYPO3 6.2

Core: Error handler (FE): PHP Warning: preg_match_all(): Compilation failed: regular expression is too large at offset 32814 in /path/typo3_src-6.2.11/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php line 1881

Core: Error handler (FE): PHP Warning: Invalid argument supplied for foreach() in /path/typo3_src-6.2.11/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php line 1896

I will try to add a patch to this bug tracker.

Hi Franz,

what's the state of this issue?

I will write a patch in September 2015.

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45132

I have found a case, where the function runs into a PHP warning.

Core: Error handler (FE): PHP Warning: Invalid argument supplied for foreach() in /var/www/web50/web/typo3_src-6.1.12/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php line 1823

$storeArrDat = $GLOBALS['TSFE']->sys_page->getHash($storeKey);

$storeArrDat:
    a:0:{}

// Traversing the keyList array and merging the static and dynamic content
        foreach ($storeArr['k'] as $n => $keyN) {

$storeArr is empty in this case.

No PHP warning should be given in this case.

I have found another error related to the last patch.
If you have a $content parameter for substituteMarkerArrayCached which has no marker at all, then an empty result is given back. This is wrong. The full $content must be returned.
Do not store into the cache with substMarkerCache if the result of preg_match_all is 0 or FALSE or $usedMarkers is empty. This will solve this issue.

$storeArr['c'] = preg_split($regex, $content);
                $storeArr['k'] = $keyList[0];
            }

if (!empty($storeArr)) {
                // Setting cache:
                $this->substMarkerCache[$storeKey] = $storeArr;
                // Storing the cached data:
                $GLOBALS['TSFE']->sys_page->storeHash($storeKey, serialize($storeArr), 'substMarkArrayCached');
                $GLOBALS['TT']->setTSlogMessage('Parsing', 0);
            }
        }
    } else {
        // Unserializing
        $storeArr = unserialize($storeArrDat);
        // Setting cache:
        $this->substMarkerCache[$storeKey] = $storeArr;

The $content must be returned without any change if no marker is inside of it.

if (
            isset($storeArr['k'])
        ) {
            $content = '';
            // Traversing the keyList array and merging the static and dynamic content
            foreach ($storeArr['k'] as $n => $keyN) {
                $content .= $storeArr['c'][$n];
                if (!is_array($valueArr[$keyN])) {
                    $content .= $valueArr[$keyN];
                } else {
                    $content .= $valueArr[$keyN][intval($wSCA_reg[$keyN]) % 2];
                    $wSCA_reg[$keyN]++;
                }
            }
            $content .= $storeArr['c'][count($storeArr['k'])];
            $GLOBALS['TT']->pull();
        }

return $content;
    }

@Franz Koch:

Please create a new issue and referee to this one. Thanks.

Markus Klein wrote:

Applied in changeset ac77e26331d94ed0521b30fdb5e70fe67fd1fffa.

This patch has the unfortunate side effect of requiring markers to be wrapped in ###, where as before you were free to use any or none.

Not only does this break old addons using that feature with no warning, but the requirement does not appear in the API

http://api.typo3.org/typo3cms/62/html/class_t_y_p_o3_1_1_c_m_s_1_1_frontend_1_1_content_object_1_1_content_object_renderer.html#a24476b64ecbbc44c0b974980ad20a70f