http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692013-02-12T22:08:40ZTYPO3 ForgeTYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1510682013-02-12T22:08:40ZHelmut Hummeltypo3@helhum.io
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Accepted</i></li></ul> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1511102013-02-13T08:49:20ZSteffen Liebigsteffen.liebig@gmx.de
<ul></ul><p>I noticed a similar bug - don't know if it's the same one but looks comparable:</p>
<p>First of all, I had problems trying to edit text elements via Page/List. I got "Oops, an error occured" without any explanation. Enabling BE/Debug and changing ProductionExceptionHandler to DebugExceptionHandler (display errors -1 -> 1) threw errors in a few php-files:</p>
<p>TYPO3\CMS\Core\Resource\Exception\FileDoesNotExistException thrown in file</p>
<p>/home/www/typo3/typo3/sysext/core/Classes/Resource/Driver/AbstractDriver.php in line 399</p>
<p>together with problems in RTE, FormEngine.php, EditDocumentController.php and alt_doc.php.</p>
<p>Disabling the RTE made it possible to take a look at the code. Correcting the links (deleting the numbers which were given to the file names while moving the site from 4.7.2 to 6.0.0/6.0.1) made it possible to reach the element via RTE again, BUT:</p>
<p>- other subpages throw similar mistakes...checking the code showed that the links are ok in the BE while in FE (mouseover), they get cut off seemingly ALL AT THE SAME POINT. It seemed to be a blank space in the data name causing the trouble, but thats not the crucial point. I replaced it by "_" in the links and in the name of the data folder without success: it lead to the same mistake AFTER the "_"</p>
<p>Assuming: it doesn't seem to matter whether I add the "_" or not - the mistake stays the same, the links are cut off somewhere between BE (RTE ?!) and FE which means they aren't usable anymore.</p>
<p>I just can join Helmut's question: "How to deal with it ?"</p> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1518292013-02-19T19:50:57ZMarc Bastian Heinrichstypo3@mbh-software.de
<ul><li><strong>File</strong> <a href="/attachments/23402">44440.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/23402/44440.patch">44440.patch</a> added</li></ul><p>Fixed this for now with attached patch</p> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1532432013-03-04T12:14:05ZHenrik Ziegenhainhenrik@ziegenhain.me
<ul></ul><p>There’s a simular issue with blank spaces in filenames/foldernames in <a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: Downloads with Whitespaces in Foldername fails after Migrate (Closed)" href="http://forge.typo3.org/issues/46007">#46007</a>.<br />The patch from Marc Bastian Heinrichs solves my problem. Thanks.</p>
<p>Could we get this into 6.0.3?</p> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1554902013-03-21T16:14:19ZThomas Allmerd4kmor@gmail.com
<ul></ul><p>Problem still persists in 6.0.4 and won't let you insert any links (to the current domain) in any RTE field... even if you edit it in the DB...<br />and you can't fix or remove the link as when opening the CE it throws the error...</p> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1555882013-03-22T07:34:05ZHenrik Ziegenhainhenrik@ziegenhain.me
<ul></ul><p>As mentioned above, the patch from Marc Bastian Heinrichs solved the issue.</p>
<p>Marc, could you push this to gerrit or how could we get this fixed?</p> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1573972013-03-28T14:23:27ZThomas Allmerd4kmor@gmail.com
<ul></ul><p>thx Marc :) <br />Patch works just fine :)</p>
<p>I now have it in my Extension tinymce_rte as I have this function "xclassed" anyway...</p>
<p><a class="external" href="https://github.com/daKmoR/TYPO3-tinymce_rte/commit/52829f2174520aa989c1897411314de4305773fc">https://github.com/daKmoR/TYPO3-tinymce_rte/commit/52829f2174520aa989c1897411314de4305773fc</a></p> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1608922013-04-23T19:52:42ZStanislas Rolland
<ul></ul><p>I am not able to reproduce this issue.</p>
<p>The RTE transformation does not cut the domain off an url entered in the "External link" tab of the link dialogue of htmlArea RTE.</p> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1608932013-04-23T20:09:20ZStanislas Rolland
<ul><li><strong>Status</strong> changed from <i>Accepted</i> to <i>Needs Feedback</i></li></ul> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1610032013-04-24T08:01:18ZHenrik Ziegenhainhenrik@ziegenhain.me
<ul></ul><p>It seems, that is has something to do with (wrong) configuration.<br />I also can`t reproduce the issue from Helmut on a fresh 6.0.4 and 6.0.5rc1</p>
<p>On another Installtion (updated from 4.5.x to 6.0.4) I can reproduce it.</p> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1610052013-04-24T08:24:04ZHenrik Ziegenhainhenrik@ziegenhain.me
<ul></ul><p>After a little more investigation I found the following:</p>
<p>Adding a link via the "External Tab" worked fine after saving.<br />Pasting the same link simply into the RTE and saving crashed it and throwed the exception from above.</p>
<p>The following worked fine:<br />Pasting the link simply into the RTE, switching to HTML-Mode and manually adding 'data-htmlarea-external="1"' the to a-tag worked fine after saving.</p>
<p>The Installation was updated from 4.7x to 6.0.4 (also reproducable with 6.0.5rc1)</p>
<hr />
<p>On a fresh and clean installation the data-attribute also is not set, but the exception is not thrown after saving.</p> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1611142013-04-24T16:48:19ZPhilipp Müllerphilipp.mueller@lavitto.ch
<ul></ul><p>The error occurs also if a text with a link will be copy-pasted from the frontend into the editor.</p>
<p><strong>Patch works fine for me, thanks Marc.</strong></p>
<p>You can reproduce the error, if you add the following code in the editor:</p>
<pre>
<link dead/link/>linktext</link>
</pre>
<p>I think the patch is much-needed in 6.0.5... It's not justifiable to provoke a fatal error because a simple "wrong" link in a text editor...</p> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1641502013-05-08T15:17:03ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>Needs Feedback</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>master</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/20639">https://review.typo3.org/20639</a></p> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1641632013-05-08T15:57:32ZAlexander Opitzopitz.alexander@googlemail.com
<ul></ul><p>I fixed this in <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: FileDoesNotExistException (Closed)" href="http://forge.typo3.org/issues/46785">#46785</a> for 6.1/6.2 there is a FolderDoesNotExistException thrown.<br />BTW: There are two lines who we need to catch.</p> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1682242013-06-04T11:24:35ZThomas Allmerd4kmor@gmail.com
<ul></ul><p>it seems that AFTER 6.0.4? we now have two different Exceptions FileDoesNotExistException and FolderDoesNotExistException... so we have to catch them both</p>
<p>I did it like this</p>
<pre>
} catch(\Exception $e) {
if ($e instanceof \TYPO3\CMS\Core\Resource\Exception\FileDoesNotExistException OR $e instanceof \TYPO3\CMS\Core\Resource\Exception\FolderDoesNotExistException) {
// no file or folder - nothing to do
} else {
// Rethrow the Exception
throw $e;
}
}
</pre> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1682702013-06-04T14:27:10ZMikael Conleymikael@wildside.dk
<ul></ul><p>Still broken in 6.0.6. Does anybody writing this code realize how bad this makes TYPO3 look to our clients?</p> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=1741332013-07-19T17:12:01ZStanislas Rolland
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li><li><strong>Assignee</strong> set to <i>Stanislas Rolland</i></li></ul><p>Was fixed in <a class="external" href="http://forge.typo3.org/issues/46785">http://forge.typo3.org/issues/46785</a></p>
<p>Fix will be included in TYPO3 6.0.7.</p> TYPO3 Core - Bug #44440: Setting an external link with domain of the backend leads to exceptionhttp://forge.typo3.org/issues/44440?journal_id=3843412018-10-02T12:15:05ZBenni Mackbenni@typo3.org
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>