Feature #4457

Improve UriBuilder

Added by Bastian Waidelich over 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Should have
Category:
MVC
Start date:
2009-09-04
Due date:
% Done:

100%

PHP Version:
Has patch:
Complexity:

Description

As discussed in the mailing lists, the current UriBuilder is not really flexible and extensible.
Besides it does not follow the FLOW3 CGL ("URIBuilder" should be "UriBuilder", "URIFor()" => "uriFor()").

In Extbase the UriBuilder is already rewritten (See #3981). These changes need to be "forward ported" to FLOW3.

Patch follows.

4457_Improve_UriBuilder.patch View - patch for package "FLOW3" (32.8 KB) Bastian Waidelich, 2009-09-04 19:43

4457_Fluid.patch View - patch for package "Fluid" (13.9 KB) Bastian Waidelich, 2009-09-04 19:43

4457_DocumentationBrowser.patch View - patch for package "DocumentationBrowser" (1.19 KB) Bastian Waidelich, 2009-09-04 19:43

4457_DocumentationBrowser.zip (2.31 KB) Bastian Waidelich, 2009-09-07 14:42

4457_FLOW3.zip (30.8 KB) Bastian Waidelich, 2009-09-07 14:42

4457_Fluid.zip (11.1 KB) Bastian Waidelich, 2009-09-07 14:42

4457_Fluid_v2.patch View (14 KB) Bastian Waidelich, 2009-09-07 15:25


Related issues

Precedes TYPO3.Fluid - Task #3987: Inconsistent attribute naming in Form view helper Resolved 2009-09-05 2009-09-05

History

#1 Updated by Bastian Waidelich over 10 years ago

Attached patches improves the UriBuilder as described and adjusts packages "Fluid" and "DocumentationBrowser" accordingly.
Please check and commit if applicable.

#2 Updated by Bastian Waidelich over 10 years ago

Bastian Waidelich wrote:

Attached patches improves the UriBuilder as described [...]

BTW: The patch even brings some new features like $uriBuilder->setAddQueryString() and $uriBuilder->setArgumentsToBeExcludedFromQueryString() which will be useful for complex scenarios

#3 Updated by Bastian Waidelich over 10 years ago

BTW┬▓: The patch resolves #3987 too.

#4 Updated by Karsten Dambekalns over 10 years ago

  • Status changed from New to Accepted
  • Assignee changed from Robert Lemke to Karsten Dambekalns

#5 Updated by Karsten Dambekalns over 10 years ago

  • Target version set to 1.0 alpha 4

#6 Updated by Bastian Waidelich over 10 years ago

If the patches won't apply cleanly, you can replace the files manually (see attached zip archives)

#7 Updated by Bastian Waidelich over 10 years ago

Attached you'll find a tweaked version of the Fluid patch:
Link/ActionViewHelper & Uri/ActionViewHelper did not call reset() on UriBuilder before creating the URI.

#8 Updated by Karsten Dambekalns over 10 years ago

  • Status changed from Accepted to Resolved
  • % Done changed from 0 to 100

Resolved as of r3131 (somehow i forgot the commit message with that change).

Also available in: Atom PDF