display error concerning FIELD:requireImage after changing FIELD:contentStyle
There is a bug when using t3s_slidernews and FIELD:contentStyle is changed.
Consequence: Change #2 is still in action and is not overridden by FIELD:onlyDefaultImage, but the value of FIELD:requireImage can't be changed in the TCEform for FIELD:contentStyle=tt_content.
E.g. FIELD:onlyDefaultImage is set to 0 (FALSE, which is default), but still only default images are displayed due to FIELD:requireImage=1
#1 Updated by Gregor Titze about 7 years ago
SUGGESTION 1: Deprecate FIELD:onlyDefaultImage and introduce FIELD:requireImage for all content styles.
REASON: The respective following fields have a similar meaning and are the root of the problem. Possible values:FIELD:requireImage (tt_news only)
- 0 = requireImage
- 1 = onlyDefaultImage
- 2 = bothImage
- 0 = FALSE (entspricht 'bothImage')
- 1 = TRUE (entspricht 'onlyDefaultImage')
I don't see a reason why 'requireImage' should not be chosen for FIELD:contentStyle=tt_content. Furthermore, FIELD:contentStyle=pages doesn't offer either option at all, but the option requireImage makes sense.
#2 Updated by Gregor Titze about 7 years ago
SUGGESTION 2: Possible refactoring of 'typo3conf/ext/t3s_jslidernews/pi1/class.tx_t3sjslidernews_pi1.php'
REASON: Depending on the content style, basic options are handled at several places or in different manners.
Problem and root of this bug: FIELD:requireImage is handled in
getSliderNewsRecords() and in
imageConf() while FIELD:onlyDefaultImage is handled in
Solution: Possibly move handling to
imageConf() which is called by
$thumbConf are set by the same code which exists 3x => capsulate, possibly in
getNews() lines 416-429
getContent() lines 577-590
getMenu() lines 710-723