Story #44982

Refactor Node Type Definition according to new syntax

Added by Sebastian Kurfuerst almost 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Content Repository
Target version:
Start date:
2013-01-30
Due date:
% Done:

100%

Estimated time:

Description

see #44955 for the to-be-implemented node type definition

How To Review

The change is currently under review in https://review.typo3.org/#/q/topic:44982,n,z

However, the change is quite big, so that's why I created some github repositories which
show the incremental changes which were made (to make the diff more manageable):

  • For each version which has been pushed to gerrit, a tag has been created named reviewX
    (e.g. review1) in all of the three repositories above
  • After every incremental change I did, Neos was (I think) fully functional for me. So you can easily
    check out any intermediate step by just cloning the respective versions from the GitHub repository.
  • just make sure to use the non-minified JavaScript while testing, and if necessary clear all caches.

HAPPY TESTING :-)

Next Steps

  • There will be one more breaking change for 1.0, which renames TYPO3.Neos.ContentTypes to
    TYPO3.Neos.NodeTypes. but aside from that, the node type definition should be quite stable now :-)
  • Furthermore, the base node types will still change once again (#45317)

Related issues

Related to Base Distribution - Task #44955: decide Node Type Definition namingResolvedSebastian Kurfuerst

Actions
Related to Base Distribution - Work Package #44971: TYPO3 Neos API DefinitionAcceptedSebastian Kurfuerst2013-06-30

Actions
Related to TYPO3 Flow Base Distribution - Feature #45164: Define syntax for validation rules in YAMLAcceptedKarsten Dambekalns2013-02-05

Actions
Precedes Base Distribution - Story #44990: Implement Node Type Schema ValidationResolved2013-01-312013-01-31

Actions
Precedes Base Distribution - Task #45309: Rename TYPO3.Neos.ContentTypes package to TYPO3.Neos.NodeTypesResolvedKarsten Dambekalns2013-02-09

Actions
Precedes Base Distribution - Story #45310: Implement enhanced @position syntax known from TypoScript also in the property panel inspector editorsNew2013-02-09

Actions
#1

Updated by Sebastian Kurfuerst almost 9 years ago

  • Category set to Content Repository
  • Target version set to 1.0 beta 1
#2

Updated by Sebastian Kurfuerst almost 9 years ago

The following TODOs still remain:

  • [MUST HAVE FOR 1.0] rename TYPO3.Neos.ContentTypes to TYPO3.Neos.NodeTypes (#45309)
  • [MUST HAVE FOR 1.0] document the new syntax (#44971)
  • [OPTIONAL] implement enhanced @position syntax (#45310)
  • [OPTIONAL] add isAbstract and isMixin to node type schema (#45311)
  • [OPTIONAL] add required child nodes to node types (#45312)
  • [VERY NICE TO HAVE] make it validatable (#44990)
#3

Updated by Sebastian Kurfuerst almost 9 years ago

  • Status changed from New to Accepted
#4

Updated by Sebastian Kurfuerst almost 9 years ago

_________CURRENT STATE_________

DONEDONE - superTypes DONE
DONEDONE - ui
  - label DONE
  - darkIcon DONE
  - icon DONE
  - inlineEditable DONE (was before: !showUneditableOverlay)
  - group DONE
  - inspector:
     groups:
         - label (DONE)
        - position (DONE, TODO extended syntax)

DONEDONE - childNodes.X DONE
    - type DONE
DONEDONE - properties.X DONE
    - type DONE
    - defaultValue DONE
    - ui
      - label DONE
      - reloadIfChanged (DONE, was reloadOnChange before)
      - inlineEditable DONE
      - inspector
              - group DONE
            - position DONE, TODO extended syntax
            - editor DONE
            - editorOptions DONE

_________TARGET________________

- superTypes DONE
- childNodes.X
    - type DONE
    - autoCreated: true
    - mandatory: true (or "required"?)
- isAbstract (#45311)
- isMixin (#45311)
- properties.X DONE
    - type DONE
    - defaultValue DONE
    - ui
        - label DONE
        - reloadIfChanged DONE
        - inlineEditable DONE
        - inspector
            - group DONE
            - position DONE, TODO extended syntax
            - editor DONE
            - editorOptions DONE
- ui
    - label DONE
    - icon DONE
    - darkIcon DONE
    - group DONE
    - inlineEditable DONE
    - inspector
        - groups.X
            - label DONE
            - position DONE (TODO: extended syntax)

____________before_____________

- superTypes
- label
- icon
- darkIcon
- group
- showUneditableOverlay
- inlineEditableProperties
- structure.X
    - type
- groups
    - label
    - priority
. properties.X
    - type
    - label
    - default
    - group
    - priority
    - reloadOnChange
    - options
    - userInterface
        - class
#5

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18147

#6

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18148

#7

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18150

#8

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18147

#9

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18150

#10

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18147

#11

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18150

#12

Updated by Gerrit Code Review almost 9 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18150

#13

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18148

#14

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18148

#15

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18164

#16

Updated by Gerrit Code Review almost 9 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18148

#17

Updated by Gerrit Code Review almost 9 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18147

#18

Updated by Gerrit Code Review almost 9 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18148

#19

Updated by Gerrit Code Review almost 9 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18147

#20

Updated by Gerrit Code Review almost 9 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18147

#21

Updated by Gerrit Code Review almost 9 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18147

#22

Updated by Gerrit Code Review almost 9 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18150

#23

Updated by Gerrit Code Review almost 9 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18150

#24

Updated by Gerrit Code Review almost 9 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18148

#25

Updated by Gerrit Code Review almost 9 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18148

#26

Updated by Gerrit Code Review almost 9 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18148

#27

Updated by Gerrit Code Review almost 9 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18148

#28

Updated by Gerrit Code Review almost 9 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18150

#29

Updated by Gerrit Code Review almost 9 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18148

#30

Updated by Gerrit Code Review almost 9 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18150

#31

Updated by Gerrit Code Review almost 9 years ago

Patch set 11 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18148

#32

Updated by Gerrit Code Review almost 9 years ago

Patch set 12 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18148

#33

Updated by Gerrit Code Review almost 9 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18150

#34

Updated by Gerrit Code Review almost 9 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18147

#35

Updated by Gerrit Code Review almost 9 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18147

#36

Updated by Gerrit Code Review almost 9 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18147

#37

Updated by Gerrit Code Review almost 9 years ago

Patch set 13 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18148

#38

Updated by Gerrit Code Review almost 9 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18150

#39

Updated by Gerrit Code Review almost 9 years ago

Patch set 11 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18147

#40

Updated by Sebastian Kurfuerst almost 9 years ago

  • Status changed from Accepted to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:883c1dfff2e590e40904bad3d140d3679ab0a24f.

#41

Updated by Gerrit Code Review almost 9 years ago

Patch set 14 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18148

Also available in: Atom PDF