Bug #45647

Controllers must not be of scope singleton

Added by Bastian Waidelich almost 9 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Must have
Start date:
2013-02-20
Due date:
% Done:

100%

Estimated time:

Description

Currently all the controllers of Flow (and the ones that you create via the kickstarter) are of scope singleton (e.g. contain the @Flow\Scope("singleton") annotation).
Usually that doesn't really make a difference, because controllers are only instantiated once.
But if we start using the same controller multiple times (say two plugin instances on one page) we'll get really weird effects..

BTW: For command controllers it's obviously OK to be singletons, but there is no advantage in doing so

#1

Updated by Bastian Waidelich almost 9 years ago

  • Status changed from New to Accepted
  • Assignee set to Bastian Waidelich
#2

Updated by Bastian Waidelich over 8 years ago

  • Project changed from TYPO3.Flow to TYPO3.Kickstart
  • Category deleted (MVC)
#3

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20591

#4

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20591

#5

Updated by Bastian Waidelich over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 2.0 has been pushed to the review server.
It is available at https://review.typo3.org/21640

#7

Updated by Bastian Waidelich over 8 years ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF